Bug 2523412

Summary:	Review Request: vmbackupd - KVM/libvirt virtual machine backup management daemon
Product:	[Fedora] Fedora	Reporter:	ilyamus <ilyamus74>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://github.com/ilyamus74-ctrl/vmbackupd
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description ilyamus 2026-08-25 12:47:13 UTC

Spec URL:
https://raw.githubusercontent.com/ilyamus74-ctrl/vmbackupd/v0.1.4/packaging/vmbackupd.spec

SRPM URL:
https://github.com/ilyamus74-ctrl/vmbackupd/releases/download/v0.1.4/vmbackupd-0.1.4-1.fc41.src.rpm

Description:
vmbackupd is a persistent local backup, replication, retention, and restore
management daemon for KVM/libvirt virtual machines.

The package provides:

- FULL and incremental backup orchestration
- Local backup storage management
- SSH replication to remote vmbackupd receivers
- Received backup catalog and restore workflows
- Cockpit web interface
- Backup retention and replica cleanup
- Recovery and safety checks for interrupted operations
- vmbackupctl command-line administration client

Upstream URL:
https://github.com/ilyamus74-ctrl/vmbackupd

Upstream release:
https://github.com/ilyamus74-ctrl/vmbackupd/releases/tag/v0.1.4

License:
GPL-3.0-or-later

COPR build:
https://copr.fedorainfracloud.org/coprs/build/10901339/

The package builds successfully for:
- fedora-rawhide-x86_64
- fedora-44-x86_64

Local fedora-review and mock testing have also been performed.

The package intentionally uses dedicated service accounts and restricted
runtime/state directory permissions for the backup daemon and restricted
SSH receiver.

In particular, /var/lib/vmbackupd/receiver-host is intentionally owned by
root:root and mode 0700 because it contains the SSH receiver host key.

Some rpmlint diagnostics concerning non-standard service UID/GID names and
restricted directory permissions are therefore intentional.

This is my first Fedora package submission and I need a packager sponsor.

Comment 1 Fedora Review Service 2026-08-25 13:21:57 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10901676
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2523412-vmbackupd/fedora-rawhide-x86_64/10901676-vmbackupd/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 ilyamus 2026-08-27 17:22:16 UTC

Thanks. I reviewed the automated fedora-review report.

The Fedora Review Service Rawhide COPR build 10901676 completed successfully.

Regarding the rpmlint diagnostics:

- "vmbackupctl" is the name of the command-line client, so the spelling
  diagnostic is a false positive.
- The dedicated vmbackupd service users/groups are intentional.
- The restrictive 0700/0750/2750 directory permissions are intentional
  because these directories contain backup state, SSH identities, and
  receiver data.
- /var/lib/vmbackupd/receiver-host is intentionally root:root mode 0700
  because it stores the SSH receiver host private key.

The upstream project is licensed GPL-3.0-or-later and the LICENSE file is
included in the upstream source archive and packaged with %license.

I have not made further packaging changes after v0.1.4 so that I can address
any concrete reviewer feedback in a follow-up release.

This is my first Fedora package submission and I still need a packager sponsor.