Bug 252418
| Summary: | Review Request: gtk-vnc - a VNC viewer widget for GTK | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Berrangé <berrange> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora-package-review, notting | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
wtogami: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-08-20 14:00:27 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 252421 | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Berrangé
2007-08-15 23:32:11 UTC
Discovered that the -devel RPM was missing a Requires: gnutls-devel, so got a new src.rpm (spec file url is unchanged) http://fedorapeople.org/~berrange/review/gtk-vnc/gtk-vnc-0.1.0-2.fc8.src.rpm Created attachment 161642 [details]
Apply this patch
Apply above patch which makes rpmlint silent.
Also update new package with chmod 644 gtk-vnc.spec
bump release tag.
Also, Do you think you should add same %doc files to all sub packages also? You can remove AUTHORS, COPYING.LIB ,ChangeLog, NEWS, README from gtk-vnc-python and gtk-vnc-devel. They are already present in gtk-vnc rpm. Applied the patch, changed the permissions (although its pointless since they get set to neccessary mode when the spec is finally imported into CVS) and removed duplicated docs. Updated src.rpm at: http://fedorapeople.org/~berrange/review/gtk-vnc/gtk-vnc-0.1.0-3.fc8.src.rpm New spec file at same url as before. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. f0781695819bd00d5ba160205723a3b4 gtk-vnc-0.1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + gtk-vnc-1.0.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + gtk-vnc-0.1.0-3.fc8 rpm =>Provides: libgtk-vnc-1.0.so.0 =>Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcairo.so.2 libdl.so.2 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgnutls.so.13 libgnutls.so.13(GNUTLS_1_3) libgobject-2.0.so.0 libgtk-vnc-1.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 rtld(GNU_HASH) + gtk-vnc-devel-0.1.0-3.fc8 rpm =>Requires: gnutls-devel gtk-vnc = 0.1.0 gtk2-devel libgtk-vnc-1.0.so.0 pkgconfig pygtk2-devel + gtk-vnc-python-0.1.0-3.fc8 rpm =>Provides: gtkvnc.so =>Requires: gtk-vnc = 0.1.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libglib-2.0.so.0 libgobject-2.0.so.0 libgtk-vnc-1.0.so.0 python(abi) = 2.5 rtld(GNU_HASH) + Not a GUI app. APPROVED. New Package CVS Request ======================= Package Name: gtk-vnc Short Description: gtk-vnc is a VNC viewer widget for GTK Owners: berrange,hbrock Branches: F-7 InitialCC: Commits by cvsextras: yes Built into rawhide |