Bug 2525945
| Summary: | Review Request: textparser - High-performance text parsing CLI and library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Boris <bbarbulovski> |
| Component: | Package Review | Assignee: | Benson Muite <benson_muite> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | benson_muite, fedora, package-review |
| Target Milestone: | --- | Flags: | benson_muite:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Boris
2026-08-30 03:12:14 UTC
> BuildRequires: pcre2-devel > BuildRequires: json-c-devel > BuildRequires: gtest-devel Consider using "BuildRequires: pkgconfig(libpcre2-32) pkgconfig(json-c) pkgconfig(gtest)" instead. > %files -n libtextparser > %{_libdir}/libtextparser.so.* Don't. This makes it easy to miss a SONAME bump happening. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files Also, since you're splitting the libs into libtextparser and libtextparser-json, might be worth to add "Provides: libtextparser-json-devel%{?_isa} = %{version}-%{release}" to the -devel package. Consider implementing the above suggestions. Building the examples is also a good way to check things work. Please add a patch to enable using system GTest as done in: https://github.com/bokic/textparser/blob/master/tests/unittests/CMakeLists.txt#L8 A Koji build that also checks whether the examples build: https://koji.fedoraproject.org/koji/taskinfo?taskID=150431869 The version check test seems to fail. Additional tests fail on s390x: https://kojipkgs.fedoraproject.org//work/tasks/1969/150431969/build.log |