Bug 2526946
| Summary: | Review Request: qcom-urm - Qualcomm userspace resource manager | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ali Erdinc Koroglu <ali.koroglu> |
| Component: | Package Review | Assignee: | Hans de Goede <hans> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | hans, package-review |
| Target Milestone: | --- | Flags: | hans:
fedora-review?
ali.koroglu: needinfo? (hans) |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ali Erdinc Koroglu
2026-09-01 17:43:53 UTC
I'm going to review this, assigning to myself. There are a number of issues with this package: 1. You have the same %changelog instead of %autochangelog as in a couple of your previous packages, please fix this for the next version. 2. The source tarbal includes floret_model_supervised.bin there are 2 issues with this: 2.1 This seems to be a set of machine-learning model weights, but there is no clear license for this in the src tarbal and I'm not quite sure what Fedora's stance is on distributing model weights. Ok about Fedora's stance on these I've found: https://lwn.net/Articles/964739/ https://lwn.net/ml/fedora-legal/CAC1cPGxUDcurpeG7M1gF5Ee=6yNjZ_RHx3N+FiqU-Bg+nUeX3A@mail.gmail.com/#t Conclusion pre-trained weights are allowed under the content rules. So now all we need is a license allowing redistribution of these (without any extra limits line no commercial use only). I guess it is time to contact upstream about this and ask them where this comes from and for them to document this and add the license under which they got this file from which ever party the file comes from. 2.2 Contextual-classifier/ContextualClassifier.cpp expects to be able to load floret_model_supervised.bin as /etc/urm/classifier/floret_model_supervised.bin but it is not part of the current qcom-urm rpms. So I think that things currently won't work, or at least there will be some missing functionality. Hello Hans, I've contacted the upstream developers about floret_mode_supervised.bin. They compile this file from https://github.com/qualcomm/fastText-workflow and they will add documentation about it. Also, this patch (https://github.com/qualcomm/userspace-resource-manager/pull/332) fixes the FT_MODEL issue in Contextual-classifier/ContextualClassifier.cpp. SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-aarch64/11034774-qcom-urm/qcom-urm.spec SRPM Url: https://packages.redhat.com/api/pulp-content/public-copr/aekoroglu/fedora/fedora-rawhide-aarch64/Packages/q/qcom-urm-0.4.10-1.fc46.src.rpm |