Bug 2529191

Summary: Review Request: perl-Params-SomeUtil - Simple, compact and correct param-checking functions
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, perl-devel, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Params-SomeUtil-1.11-1.fc46 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-09-11 15:28:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2529000, 2529071, 2531463    

Description Paul Howarth 2026-09-06 15:44:24 UTC 
Spec URL: https://www.city-fan.org/~paul/extras/perl-Params-SomeUtil/perl-Params-SomeUtil.spec

SRPM URL: https://www.city-fan.org/~paul/extras/perl-Params-SomeUtil/perl-Params-SomeUtil-1.09-1.fc46.src.rpm

Description:
Params::SomeUtil provides a basic set of importable functions that makes
checking parameters much easier. This module is a fork of version 1.07 of
Params::Util with some additional bug fixes.

While they can be (and are) used in other contexts, the main point behind this
module is that the functions both Do What You Mean, and Do The Right Thing, so
they are most useful when you are getting params passed into your code from
someone and/or somewhere else and you can't really trust the quality.  Thus,
Params::SomeUtil is of most use at the edges of your API, where params and data
are coming in from outside your code.

The functions provided by Params::SomeUtil check in the most strictly correct
manner known, are documented as thoroughly as possible so their exact behavior
is clear, and heavily tested so make sure they are not fooled by weird data and
Really Bad Things.

Fedora Account System Username: pghmcfc

This is a fork of Params::Util since that module's upstream seems to be reluctant to release any updates. Params::SomeUtil is a new dependency of perl-Data-OptList.

rpmlint reports that the FSF address is out of date in the LICENSE file. I have reported this upstream at https://github.com/uperl/Params-SomeUtil/issues/7

Reproducible: Always
Comment 1 Petr Pisar 2026-09-07 15:30:39 UTC 
URL and Source0 addresses are Ok.
Source0 archive (SHA-512: 6e6f24917c2cdc13acfd66823e2377f283f2b94c729f9a29e789f24534444358a82b57c6a0bd52214339764c9c9d37d3b75ec4c7bdc75b3c9693a6065912aced) is original. Ok.
Summary verified from lib/Params/SomeUtil.pm. Ok.
Description verified from lib/Params/SomeUtil.pm. Ok.
License verified in: README.md, lib/Params/SomeUtil.pm, Makefile.PL, LICENSE, README. Ok.
XS code found, no noarch BuildArch is Ok.

TODO: Change minimal perl(Test::More) version to '>= 0.87' (Makefile.PL:82).
TODO: Constrain perl(Scalar::Util) dependency with '>= 1.18' (Makefile.PL:78).
TODO: Constrain perl version with 'perl(:VERSION) >= 5.5.3' (Makefile.PL:3).

TODO: Unset PERL_PARAMS_UTIL_PP and PERL_PARAMS_SOMEUTIL_PP environement variables in the %check section to make the tests more reproducible.

All tests pass. Ok.

$ rpmlint perl-Params-SomeUtil.spec ../SRPMS/perl-Params-SomeUtil-1.09-1.fc46.src.rpm ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.10.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 3

perl-Params-SomeUtil.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Params-SomeUtil/LICENSE
=== 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 6 filtered, 1 badness; has taken 0.4 s ==
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm
drwxr-xr-x    2 root     root                        0 Sep  6 02:00 /usr/lib/.build-id
drwxr-xr-x    2 root     root                        0 Sep  6 02:00 /usr/lib/.build-id/0f
lrwxrwxrwx    1 root     root                       72 Sep  6 02:00 /usr/lib/.build-id/0f/0708f600f96a9b77c8ba78aff020931d91c765 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Params/SomeUtil/SomeUtil.so
drwxr-xr-x    2 root     root                        0 Sep  6 02:00 /usr/lib64/perl5/vendor_perl/Params
-rw-r--r--    1 root     root                    25551 May  4 00:04 /usr/lib64/perl5/vendor_perl/Params/SomeUtil.pm
drwxr-xr-x    2 root     root                        0 Sep  6 02:00 /usr/lib64/perl5/vendor_perl/auto/Params
drwxr-xr-x    2 root     root                        0 Sep  6 02:00 /usr/lib64/perl5/vendor_perl/auto/Params/SomeUtil
-rwxr-xr-x    1 root     root                    23544 Sep  6 02:00 /usr/lib64/perl5/vendor_perl/auto/Params/SomeUtil/SomeUtil.so
drwxr-xr-x    2 root     root                        0 Sep  6 02:00 /usr/share/doc/perl-Params-SomeUtil
-rw-r--r--    1 root     root                     6668 May  4 00:06 /usr/share/doc/perl-Params-SomeUtil/Changes
-rw-r--r--    1 root     root                    17983 Feb  7  2026 /usr/share/doc/perl-Params-SomeUtil/README
drwxr-xr-x    2 root     root                        0 Sep  6 02:00 /usr/share/licenses/perl-Params-SomeUtil
-rw-r--r--    1 root     root                    20576 Feb  6  2026 /usr/share/licenses/perl-Params-SomeUtil/LICENSE
-rw-r--r--    1 root     root                     6492 Sep  6 02:00 /usr/share/man/man3/Params::SomeUtil.3pm.gz
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm | sort -f | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit)
      1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit)
      1 libperl.so.5.44()(64bit)
      1 perl(:MODULE_COMPAT_5.44.0)
      1 perl(:VERSION) >= 5.5.30
      1 perl(DynaLoader)
      1 perl(Exporter)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(vars)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm | sort -f | uniq -c
      1 perl(Params::SomeUtil) = 1.09
      1 perl-Params-SomeUtil = 1.09-1.fc46
      1 perl-Params-SomeUtil(x86-64) = 1.09-1.fc46
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-Params-SomeUtil-1.09-1.fc46.x86_64.rpm 
Binary dependencies are resolvable. Ok.

The package build in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=149982883). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the TODO items before building this package.
The package is APPROVED.
Comment 2 Fedora Admin user for bugzilla script actions 2026-09-11 14:26:21 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Params-SomeUtil
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Comment 3 Fedora Update System 2026-09-11 15:23:59 UTC 
FEDORA-2026-f77657b90a (perl-Params-SomeUtil-1.11-1.fc46) has been submitted as an update to Fedora 46.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-f77657b90a
Comment 4 Fedora Update System 2026-09-11 15:28:36 UTC 
FEDORA-2026-f77657b90a (perl-Params-SomeUtil-1.11-1.fc46) has been pushed to the Fedora 46 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 5 Fedora Update System 2026-09-11 18:17:33 UTC 
FEDORA-2026-75bbf9532e (perl-Data-OptList-0.115-1.fc45 and perl-Params-SomeUtil-1.11-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-75bbf9532e
Comment 6 Fedora Update System 2026-09-11 18:48:42 UTC 
FEDORA-2026-17724ee5ba (perl-Params-SomeUtil-1.11-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-17724ee5ba
Comment 7 Fedora Update System 2026-09-11 18:48:43 UTC 
FEDORA-EPEL-2026-82011a8cc9 (perl-Params-SomeUtil-1.11-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-82011a8cc9
Comment 8 Fedora Update System 2026-09-11 18:48:43 UTC 
FEDORA-EPEL-2026-81f2ed7792 (perl-Params-SomeUtil-1.11-1.el10_3) has been submitted as an update to Fedora EPEL 10.3.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-81f2ed7792
Comment 9 Fedora Update System 2026-09-11 18:48:44 UTC 
FEDORA-EPEL-2026-d05a3b2ceb (perl-Params-SomeUtil-1.11-1.el8) has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-d05a3b2ceb
Comment 10 Fedora Update System 2026-09-12 01:44:18 UTC 
FEDORA-2026-75bbf9532e has been pushed to the Fedora 45 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-75bbf9532e`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-75bbf9532e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 11 Fedora Update System 2026-09-12 01:54:56 UTC 
FEDORA-EPEL-2026-81f2ed7792 has been pushed to the Fedora EPEL 10.3 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-81f2ed7792

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 12 Fedora Update System 2026-09-12 02:00:57 UTC 
FEDORA-EPEL-2026-85bf2956ac has been pushed to the Fedora EPEL 10.4 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-85bf2956ac

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 13 Fedora Update System 2026-09-12 02:08:37 UTC 
FEDORA-2026-17724ee5ba has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-17724ee5ba`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-17724ee5ba

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 14 Fedora Update System 2026-09-12 02:14:01 UTC 
FEDORA-EPEL-2026-82011a8cc9 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-82011a8cc9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 15 Fedora Update System 2026-09-12 02:15:43 UTC 
FEDORA-EPEL-2026-d05a3b2ceb has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-d05a3b2ceb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 16 Fedora Update System 2026-09-12 02:26:00 UTC 
FEDORA-2026-5e831d3704 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-5e831d3704`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-5e831d3704

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 17 Paul Howarth 2026-09-12 12:10:51 UTC 
Thanks for the review Petr.

I set the Test::More version requirement to 0.88 because some of the tests use done_testing, which was introduced in that version (well, 0.87_01).
Comment 18 Fedora Update System 2026-09-15 00:17:53 UTC 
FEDORA-2026-75bbf9532e (perl-Data-OptList-0.115-1.fc45 and perl-Params-SomeUtil-1.11-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 19 Fedora Update System 2026-09-15 00:41:32 UTC 
FEDORA-2026-5e831d3704 (perl-Params-SomeUtil-1.11-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 20 Fedora Update System 2026-09-15 01:03:45 UTC 
FEDORA-2026-17724ee5ba (perl-Params-SomeUtil-1.11-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 21 Fedora Update System 2026-09-20 00:38:37 UTC 
FEDORA-EPEL-2026-81f2ed7792 (perl-Params-SomeUtil-1.11-1.el10_3) has been pushed to the Fedora EPEL 10.3 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 22 Fedora Update System 2026-09-20 00:50:18 UTC 
FEDORA-EPEL-2026-82011a8cc9 (perl-Params-SomeUtil-1.11-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 23 Fedora Update System 2026-09-20 01:01:18 UTC 
FEDORA-EPEL-2026-85bf2956ac (perl-Params-SomeUtil-1.11-1.el10_4) has been pushed to the Fedora EPEL 10.4 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 24 Fedora Update System 2026-09-20 02:17:27 UTC 
FEDORA-EPEL-2026-d05a3b2ceb (perl-Params-SomeUtil-1.11-1.el8) has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.