Bug 2529342
| Summary: | Review Request: python-esp-pylib - Library for logging, utils and constants for Espressif Systems' projects | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karolina Surma <ksurma> |
| Component: | Package Review | Assignee: | Miro Hrončok <mhroncok> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mhroncok, package-review |
| Target Milestone: | --- | Flags: | mhroncok:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-09-22 11:04:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2527296 | ||
|
Description
Karolina Surma
2026-09-07 10:29:39 UTC
Other than missing %doc README.md, this looks quite sane. I updated the artifacts under the same links, PTAL, and if OK, please approve the package. Thank you. I sued this for AI-assisted review (to see how good it goes): It called out one thing: `BuildArch: noarch` and `BuildRequires: python3-devel` are separated from the rest of the preamble by blank lines in a way that leaves a slightly unusual double blank line before `%global _description`. Purely cosmetic, no guideline violation. ---- Anyway, this package is APPROVED (by a human). It's a small Python package that follows the guidelines closely. https://forge.fedoraproject.org/packaging/guidelines/commit/74a09708 -- you might want to drop the python3-devel BR entirely. The Pagure repository was created at https://src.fedoraproject.org/rpms/python-esp-pylib Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` FEDORA-2026-d60a585285 (python-esp-pylib-1.1.4-1.fc46) has been submitted as an update to Fedora 46. https://bodhi.fedoraproject.org/updates/FEDORA-2026-d60a585285 FEDORA-2026-d60a585285 (python-esp-pylib-1.1.4-1.fc46) has been pushed to the Fedora 46 stable repository. If problem still persists, please make note of it in this bug report. |