Bug 253024
| Summary: | Review Request: makehuman - Modeling of three-dimensional humanoid characters | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-09 17:38:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 253022 | ||
| Bug Blocks: | |||
|
Description
Nicolas Chauvet (kwizart)
2007-08-16 17:21:52 UTC
First comment:
* update-desktop-database
- Not needed because this desktop does not contain any mimetypes.
* rpmlint
- Please explain what the folloiwng zero-length files are for.
-------------------------------------------------------------
/usr/share/makehuman/targets/ns_tongue/tongue_camaleon.target
/usr/share/makehuman/targets/ns_teeth/teeth_gengivite.target
/usr/share/makehuman/targets/l_ear2/l_ear_incisura_intertragica_down.target
/usr/share/makehuman/targets/ns_abdomen/abdomen_twist.target
--------------------------------------------------------------
* Timestamp
- This package installs many "data" files and keeping timestamps
on those files is _very_ desirable.
* First add the option 'INSTALL="install -p"' to 'make install'
for files under /usr/share/makehuman/base.* .
- For the rest of the files, almost of them are installed by
"cp -R", like:
---------------------------------------------------------------
make[2]: Entering directory `/builddir/build/BUILD/makehuman-0.9/data'
make[2]: Nothing to be done for `install-exec-am'.
/builddir/build/BUILD/makehuman-0.9/install-sh -d
/var/tmp/makehuman-0.9-1.fc8-root-mockbuild/usr/share/makehuman
cp -R ./targets /var/tmp/makehuman-0.9-1.fc8-root-mockbuild/usr/share/makehuman
cp -R ./rotations /var/tmp/makehuman-0.9-1.fc8-root-mockbuild/usr/share/makehuman
cp -R ./rib_data /var/tmp/makehuman-0.9-1.fc8-root-mockbuild/usr/share/makehuman
----------------------------------------------------------------
So, changing "cp -R" to "cp -pR" will keep timestamps on
almost all files. Please fix the corresponding Makefile(s).
ping? Spec URL: http://kwizart.free.fr/fedora/6/testing/makehuman/makehuman.spec SRPM URL: http://kwizart.free.fr/fedora/6/testing/makehuman/makehuman-0.9-2.kwizart.fc6.src.rpm Description: Modeling of three-dimensional humanoid characters The above issues are fixed. Okay, almost good.
For -2:
? Icon
- Can you find some icon suitable for the desktop of this package?
(not a blocker)
* License
- seems to be GPLv2+.
* Desktop Category
- Category "Application" is deprecated and should be removed.
Spec URL: http://kwizart.free.fr/fedora/6/testing/makehuman/makehuman.spec SRPM URL: http://kwizart.free.fr/fedora/6/testing/makehuman/makehuman-0.9-3.kwizart.fc6.src.rpm Description: Modeling of three-dimensional humanoid characters I've took an icon from the makehuman pixmaps subdir. Issues are fixed with release 3. Okay. ---------------------------------------------------------- This package (makehuman) is APPROVED by me ---------------------------------------------------------- New Package CVS Request ======================= Package Name: makehuman Short Description: Modeling of three-dimensional humanoid characters Owners: kwizart Branches: F-7 FC-6 EL-5 EL-4 InitialCC: <empty> Commits by cvsextras: yes cvs done. Please rebuild also on F-7, FC-6 and close this bug. I don't knwo to request mhgui to be in the buildroot for F-7. I've send a mail to the rel-eng but didn't get any answears now... maybe i need to tag makehuman for F-7 first?... ping to rel-eng team again. Or it may be faster that you request to move mhgui from testing to stable. Please close this bug when rebuild is done. |