Bug 253579
| Summary: | Review Request: php-pecl-memcache - Extension to work with the Memcached caching daemon | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | Package Review | Assignee: | Matthias Saou <matthias> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, matthias, notting |
| Target Milestone: | --- | Flags: | matthias:
fedora-review+
petersen: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-31 13:43:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Remi Collet
2007-08-20 17:19:43 UTC
I Add Matthias in CC: as is the maintener for this package at rpmforge. @Matthias : my spec is closed to your. We can work as co-maintener for this if you want. I will push it to Fedora and EPEL after review. Remi. Veeeery nice, clean and portable spec file. This will be a real pleasure to review. Thanks for CC'ing me, feel free to do it again ;-) I just went through the ReviewGuidelines, double checked the license and tested a Fedora 7 x86_64 build. It all looks fine. Just two minor nitpicks : - Some sections of your spec file are separated by 2 spaces, others only by one. It would be more readable if all were separated by 2 IMHO :-) (before %prep, %build and %changelog). - It's harmless here, but you should always escape macros in comments and the %changelog, so change "use %name rather than %pecl_name" to "use %%name rather than %%pecl_name" or even simply "use name rather than pecl_name". Again, no big deal, but if some day you put some multi-line macro, it'll do nasty stuff ;-) APPROVED even as-is in any case, great work on PHP packaging, keep it up! New Package CVS Request ======================= Package Name: php-pecl-memcache Short Description: Extension to work with the Memcached caching daemon Owners: remi Branches: F-7, FC-6, EL-5, EL-4 InitialCC: Cvsextras Commits: yes request done Push to CVS with typo changes. Thanks for the review. |