Bug 253588

Will review this

Testing BZ problem

Here's the initial review. Most things are fine, with apart from the problems
noted below. I've built it on my Rawhide x86_64 box a few days ago, but
currently it does not build in mock:

- F7 does not have ocaml-findlib{,-devel}:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=169938

Building against Rawhide on Koji failed mysteriously, trying against dist-f8
now, but it looked like a build server problem anyway.

Documentation should probably be split into -doc, as it pertains the use of
cilly as well, and introduces the infrastructure in general. Your call.

Oh, and perl(CilConfig) should provide a version number!

MUST
FAILED:
• clean buildroot before install: no
• rpmlint
ocaml-cil.src:66: W: unversioned-explicit-provides perl(CilConfig)

• build dependencies complete: : can't build on FC7, no ocaml-findlib*
• -doc: might want to create separate -doc, since it also contains documentation
on cilly 


PASSED:

• package name: hmm. it produces a tool that is useful for programming in C, so
in a way it's an application written in OCaml, but to customize it you need to
write in OCaml, so it's an OCaml lib. probably OK as it is
• spec file name: matches 
• package guideline-compliant: yes
• license complies with guidelines: yes
• license field accurate: yes
• license file not deleted: yes
• spec in US English: yes
• spec legible: yes
• source matches upstream: yes
• builds under >= 1 archs, others excluded
• own all directories: yes
• no dupes in %files: yes
• permission: yes
• %clean must clean RPM_BUILD_ROOT: yes
• macros used consistently: yes
• must contain code: yes
• headers in -devel: yes
• devel must require versioned base package: yes
• filenames UTF-8

SHOULD
FAILED:
• package build in mock on all architectures 

PASSED:
• package functioned as described: yes
• scriplets are sane: yes
• other subpackages should require versioned base: yes
• require package, not files: yes

Build on Koji failed for F8 as well. It builds fine for i386, x86_64 has not
finished, but you need to exclude PPC as well:
http://koji.fedoraproject.org/koji/taskinfo?taskID=169952

Also note that URL has changed to http://cil.sourceforge.net/

ping

Hi yes, still here, and will get around to this RSN!

I'm unclear from Koji what the actual error was on PPC.  (Unfortunately
I don't have access to an actual PPC to test).

You said 'clean buildroot before install', but I think I'm doing that.
However I moved the commands around to make that clear.

Spec: http://www.annexia.org/tmp/ocaml/ocaml-cil.spec
SRPM: http://www.annexia.org/tmp/ocaml/ocaml-cil-1.3.6-3.fc8.src.rpm

+* Wed Nov  7 2007 Richard W.M. Jones <rjones> - 1.3.6-3
+- Change upstream URL.
+- perl(CilConfig) set to package version
+- Split out documentation into a separate -doc package.
+ 

Didn't notice the update -- sorry. Will get back to it before this weekend.

You need to excludeArch ppc as well:
http://koji.fedoraproject.org/koji/taskinfo?taskID=244937

(might want to bug the upstream developers about Linux/ppc support, since the
ppc target is supported for OS X)

Completed build: http://koji.fedoraproject.org/koji/taskinfo?taskID=244948

Question: does ocaml-cil work without the .ml and .o files? From the packaging
guidelines (http://fedoraproject.org/wiki/Packaging/OCaml):

*.o files are not normally included. There is however one exception -- if file
is needed for link (like gtkInit.cmx and gtkInit.o in lablgtk or std_exit.cmx
and std_exit.o in OCaml itself), then it should be included.

*.ml files are not normally included. The exception is if the file describes a
module signature and there is no corresponding .mli file, then the .ml file
should be included. (Note that Debian is more permissive and they often
distribute *.ml files, allowing the programmer to peek at the implementation of
a module).

Richard, any chance you could update the package soon? Thanks.

Probably won't be this week, but it's still on my list ...

This is the updated package:

Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-cil.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-cil-1.3.6-4.fc8.src.rpm

* Wed Nov  7 2007 Richard W.M. Jones <rjones> - 1.3.6-4
- ExcludeArch ppc - CIL doesn't build on PPC as it turns out.

The *.ml files are required.  We can't strip cilly.byte.exe because
strip will remove the bytecode from the file.

Builds on i386 and x86_64; rpmlint output is clean, apart from the *.ml and
cilly.byte.exe file that's been discussed.

Looks good -- APPROVED.

New Package CVS Request
=======================
Package Name: ocaml-cil
Short Description: CIL - Infrastructure for C Program Analysis and Transformation
Owners: rjones
Branches: F-8
InitialCC: rjones
Cvsextras Commits: yes

cvs done. 

Please make sure to file a bug and block bug 239077 for the ppc build issues. 

I added two new bugs in fact, because bug 239077 was unrelated to the
reason for the ExcludeArch.

  ppc:   bug 435546
  ppc64: bug 435545

F-8: http://koji.fedoraproject.org/koji/taskinfo?taskID=481892
devel: http://koji.fedoraproject.org/koji/taskinfo?taskID=481885