Bug 253597

Summary: Wrong colours connecting to OSX server
Product: [Fedora] Fedora Reporter: Bastien Nocera <bnocera>
Component: gtk-vncAssignee: Daniel Berrangé <berrange>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: hbrock
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-08-22 23:44:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot.png
none
Fix endianness handling, and BGR pixel formats
none
Fix endianness handling, and BGR pixel formats none

Description Bastien Nocera 2007-08-20 19:03:51 UTC
gtk-vnc-0.1.0-3.fc8 on x86_64
OXSVNC 1.71 on MacOS X 10.4.10 (iirc)

The colours are wrong (as per screenshot). The background is supposed to be blue.

Comment 1 Bastien Nocera 2007-08-20 19:03:54 UTC
Created attachment 161913 [details]
Screenshot.png

Comment 2 Daniel Berrangé 2007-08-22 16:10:54 UTC
Created attachment 162073 [details]
Fix endianness handling, and BGR pixel formats

The attached patch should fix GTK-VNC's handling of endianness differences
between client & server by reversing the pixel shifts. It also fixes handling
of BGR pixel formats by removing some redundant & wrong logic.

Comment 3 Bastien Nocera 2007-08-22 16:14:41 UTC
Comment on attachment 162073 [details]
Fix endianness handling, and BGR pixel formats

<snip>
>-#define DEBUG 0
>+#define DEBUG 1

Is debug supposed to be left on?

Comment 4 Daniel Berrangé 2007-08-22 16:19:56 UTC
Created attachment 162075 [details]
Fix endianness handling, and BGR pixel formats

No DEBUG wasn't supposed to be left on.

Comment 5 Daniel Berrangé 2007-08-22 22:50:25 UTC
Committed to CVS, build pending....

* Wed Aug 22 2007 Daniel P. Berrange <berrange> - 0.1.0-4.fc8
- Fix mixed endian handling & BGR pixel format (rhbz #253597)
- Clear widget areas outside of framebuffer (rhbz #253599)
- Fix off-by-one in python demo

Comment 6 Daniel Berrangé 2007-08-22 23:44:36 UTC
Build complete, in rawhide.