Bug 253805
| Summary: | Review Request: scim-array - Array 30 input method engine for SCIM | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ding-Yi Chen <dchen> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 7 | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-30 23:54:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ding-Yi Chen
2007-08-22 01:19:53 UTC
Change License to GPLv2 and remove INSTALL from %doc remove .la files not required to pass prefix to %configure After .la files removed, the rpmbuild -bi scim-array.spec states that:
====================================================
error: Installed (but unpackaged) file(s) found:
/usr/lib64/scim-1.0/1.4.0/IMEngine/array.la
/usr/lib64/scim-1.0/1.4.0/SetupUI/array-imengine-setup.la
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/lib64/scim-1.0/1.4.0/IMEngine/array.la
/usr/lib64/scim-1.0/1.4.0/SetupUI/array-imengine-setup.la
===========================================
What should I do with it?
The SPEC is updated according to COMMENTS. New Spec URL: http://dchen.fedorapeople.org/files/rpms/scim-array.spec New SRPM URL: http://dchen.fedorapeople.org/files/rpms/scim-array-0.0.1- 1.fc7.src.rpm package is not owning /usr/share/scim/Array SPEC file update according to Comment #6 New Spec URL: http://dchen.fedorapeople.org/files/rpms/scim-array.spec New SRPM URL: http://dchen.fedorapeople.org/files/rpms/scim-array-0.0.1- 2.src.rpm SPEC file updated.
Remove following files in %file section
%{_datadir}/scim/Array/array-shortcode.cin
%{_datadir}/scim/Array/array-special.cin
%{_datadir}/scim/Array/array30.cin
New Spec URL: http://dchen.fedorapeople.org/files/rpms/scim-array.spec
New SRPM URL: http://dchen.fedorapeople.org/files/rpms/scim-array-0.0.1-
3.fc7.src.rpm
W: scim-array macro-in-%changelog file Macros are expanded in %changelog too, which can in unfortunate cases lead to the package not building at all, or other subtle unexpected conditions that affect the build. Even when that doesn't happen, the expansion results in possibly "rewriting history" on subsequent package revisions and generally odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros in %changelog altogether, or use two '%'s to escape them, like '%%foo'. replace changelog as given below
* Fri Aug 17 2007 Ding-Yi Chen <dchen> - 0.0.1-3
- Remove following files in %%file section
%%{_datadir}/scim/Array/array-shortcode.cin
%%{_datadir}/scim/Array/array-special.cin
%%{_datadir}/scim/Array/array30.cin
* Fri Aug 17 2007 Ding-Yi Chen <dchen> - 0.0.1-2
- Add %%{_datadir}/scim/Array in %%file section.
SPEC file updated. Changes: Remove tags in the changelog section New Spec URL: http://dchen.fedorapeople.org/files/rpms/scim-array.spec New SRPM URL: http://dchen.fedorapeople.org/files/rpms/scim-array-0.0.1- 4.fc7.src.rpm Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 1cc73fbc2990898fbee2cfff4c718b15 scim-array-0.0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Provides: array-imengine-setup.so array.so + Requires: libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.4) libcairo.so.2 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgtk-x11-2.0.so.0 libm.so.6 libpango-1.0.so.0 libpangocairo-1.0.so.0 libscim-1.0.so.8 libscim-1.0.so.8(LIBSCIM_1.0) libscim-gtkutils-1.0.so.8 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) rtld(GNU_HASH) scim + Not a GUI app. APPROVED. New Package CVS Request ======================= Package Name: scim-array Short Description: Array 30 Input Method Engine for SCIM Owners: dchen Branches: F-7 InitialCC: dchen Cvsextras Commits: yes cvs done. |