Bug 253813

http://cchance.fedorapeople.org/20070822_cjkuni/cjkuni-fonts.spec

http://cchance.fedorapeople.org/20070822_cjkuni/cjkuni-fonts-0.1-1.fc8.src.rpm

I am still wondering if it is better to split the ukai and uming fonts into
separate packages.  This might also be better for casual Chinese users who
don't need them both.  Another way to do that would be to subpackage them from
the same srpm - that would be less package maintainence work anyway.

Anyway I think the base name should be cjkunifonts like the upstream project.
I don't mind if the package is called cjkunifonts or cjkunifonts-fonts say.
http://www.freedesktop.org/wiki/Software/CJKUnifonts

I agree to split ukai and uming fonts into separate packages. Generally users
will accept the installation of both even most users only need uming for daily use.

Okay, let's use cjkunifonts-fonts as package name.

I suggest using the name cjkunifonts for the source package or maybe cjkuni-fonts.

Thanks.

I think it would be better to generate the static fonts files at build time
rather than in %post like sazanami-fonts now does.  So only fc-cache
needs to be run in the scripts.

rpmlint on srpm:
W: cjkuni-fonts summary-ended-with-dot Chinese TrueType Font -- Simplified and
Traditional Chinese Ming and Kai Face.
E: cjkuni-fonts description-line-too-long Chinese TTF Fonts donated by Arphic
company, with additional Hong Kong characters by Hong Kong font project. Read
license files for details.
W: cjkuni-fonts invalid-license Arphic Public License
W: cjkuni-fonts invalid-license GPL-like
W: cjkuni-fonts unversioned-explicit-obsoletes ttfonts-zh_CN
W: cjkuni-fonts unversioned-explicit-obsoletes ttfonts-zh_TW
W: cjkuni-fonts unversioned-explicit-obsoletes ttf-moe_sung
W: cjkuni-fonts unversioned-explicit-obsoletes ttf-arphic_bming
W: cjkuni-fonts unversioned-explicit-obsoletes ttfonts-zh_CN
W: cjkuni-fonts unversioned-explicit-obsoletes ttfonts-zh_TW
W: cjkuni-fonts unversioned-explicit-obsoletes ttf-moe_kai
W: cjkuni-fonts unversioned-explicit-obsoletes ttf-arphic_bkai

rpmlint output on binary packages:

W: cjkuni-fonts-ukai non-conffile-in-etc /etc/ghostscript/cidfmap.zh_CN
W: cjkuni-fonts-ukai non-conffile-in-etc /etc/ghostscript/FAPIcidfmap.zh_CN
W: cjkuni-fonts-ukai non-conffile-in-etc /etc/ghostscript/FAPIcidfmap.zh_TW
W: cjkuni-fonts-ukai non-conffile-in-etc /etc/ghostscript/CIDFnmap.zh_TW
W: cjkuni-fonts-ukai non-conffile-in-etc /etc/ghostscript/cidfmap.zh_TW
W: cjkuni-fonts-ukai symlink-should-be-relative
/etc/X11/fontpath.d/cjkuni-fonts-ukai /usr/share/fonts/cjkuni-fonts-ukai
W: cjkuni-fonts-ukai non-conffile-in-etc /etc/ghostscript/CIDFnmap.zh_CN
W: cjkuni-fonts-ukai invalid-license Arphic Public License
W: cjkuni-fonts-ukai invalid-license GPL-like
W: cjkuni-fonts-ukai obsolete-not-provided ttfonts-zh_CN
W: cjkuni-fonts-ukai obsolete-not-provided ttfonts-zh_TW
W: cjkuni-fonts-ukai obsolete-not-provided ttf-moe_kai
W: cjkuni-fonts-ukai obsolete-not-provided ttf-arphic_bkai
W: cjkuni-fonts-uming non-conffile-in-etc /etc/ghostscript/cidfmap.zh_CN
W: cjkuni-fonts-uming non-conffile-in-etc /etc/ghostscript/FAPIcidfmap.zh_CN
W: cjkuni-fonts-uming non-conffile-in-etc /etc/ghostscript/FAPIcidfmap.zh_TW
W: cjkuni-fonts-uming non-conffile-in-etc /etc/ghostscript/CIDFnmap.zh_TW
W: cjkuni-fonts-uming non-conffile-in-etc /etc/ghostscript/cidfmap.zh_TW
W: cjkuni-fonts-uming non-conffile-in-etc /etc/ghostscript/CIDFnmap.zh_CN
W: cjkuni-fonts-uming symlink-should-be-relative
/etc/X11/fontpath.d/cjkuni-fonts-uming /usr/share/fonts/cjkuni-fonts-uming
W: cjkuni-fonts-uming invalid-license Arphic Public License
W: cjkuni-fonts-uming invalid-license GPL-like
W: cjkuni-fonts-uming obsolete-not-provided ttfonts-zh_CN
W: cjkuni-fonts-uming obsolete-not-provided ttfonts-zh_TW
W: cjkuni-fonts-uming obsolete-not-provided ttf-moe_sung
W: cjkuni-fonts-uming obsolete-not-provided ttf-arphic_bming
W: cjkuni-fonts-uming dangerous-command-in-%post ln

Created attachment 173401 [details]
cjkuni-fonts.spec-1.patch

some initial suggested text changes

Just remembered again: the urls should be on an external site please
so that everyone can see them.

Created attachment 176161 [details]
cjkunifonts.spec-2.patch

Here are some more changes and some of the changes again from the first patch.

Please be consistent with the vertical spacing: either use one or two
spaces between each section.  In this patch I made all the sections
double-spaced but single-spaced is fine too.

BTW IMHO it would be easier to do the %install in parallel for uming and ukai
like in the initial version - that would make maintenance easier.

If you're unclear about any of the changes please feel free to ask questions.
:)

Please also rename the spec file, thanks.

http://cchance.fedorapeople.org/20070829_cjkunifonts/cjkunifonts.spec

http://cchance.fedorapeople.org/20070829_cjkunifonts/cjkunifonts-0.1.20060928-1.fc8.src.rpm

Thanks for the update and unifying %install for uming and ukai -
looks much clearer now. :)

rpmlint still gives:
W: cjkunifonts unversioned-explicit-obsoletes ttfonts-zh_CN
W: cjkunifonts unversioned-explicit-obsoletes ttfonts-zh_TW
W: cjkunifonts unversioned-explicit-obsoletes ttfonts-zh_CN
W: cjkunifonts unversioned-explicit-obsoletes ttfonts-zh_TW

These need to be fixed.

All the CID map files need to be updated to the new directory paths.

Created attachment 177821 [details]
cjkunifonts.spec-3.patch

A few more fixes (I forget to mention "Arphic" was added as a license
to the fedora wiki Licenses page).

After this still get:
W: cjkunifonts-uming non-conffile-in-etc /etc/ghostscript/cidfmap.zh_CN
W: cjkunifonts-uming non-conffile-in-etc /etc/ghostscript/FAPIcidfmap.zh_CN
W: cjkunifonts-uming non-conffile-in-etc /etc/ghostscript/FAPIcidfmap.zh_TW
W: cjkunifonts-uming non-conffile-in-etc /etc/ghostscript/CIDFnmap.zh_TW
W: cjkunifonts-uming non-conffile-in-etc /etc/ghostscript/cidfmap.zh_TW
W: cjkunifonts-uming symlink-should-be-relative
/etc/X11/fontpath.d/cjkunifonts-uming /usr/share/fonts/cjkunifonts-uming
W: cjkunifonts-uming non-conffile-in-etc /etc/ghostscript/CIDFnmap.zh_CN
W: cjkunifonts-uming obsolete-not-provided ttfonts-zh_CN
W: cjkunifonts-uming obsolete-not-provided ttfonts-zh_TW

and similarly on -ukai.

The CID files should live in /usr/share/ghostscript/conf.d/ not /etc/ghostscript
as in fonts-japanese.

Please kindly review:

http://cchance.fedorapeople.org/20070829_cjkunifonts_2/cjkunifonts.spec

http://cchance.fedorapeople.org/20070829_cjkunifonts_2/cjkunifonts-0.1.20060928-1.fc8.src.rpm

Created attachment 177961 [details]
cjkunifonts.spec-4.patch

Fix license and dangling symlink.  The symlinks don't need to be forced either.


Just for the record too: usual practice is to bump the release field
for each new srpm.

Patched with comment# 22, overwritten on url in comment# 21.

Please bump the release number in future so that the srpm's don't get overwritten.
Then you could also just use one dir (eg
http://cchance.fedorapeople.org/cjkunifonts/) for the review.

The CID files still need to be updated.

Here is the review:

+ rpmlint output:

W: cjkunifonts-ukai symlink-should-be-relative
/etc/X11/fontpath.d/cjkunifonts-ukai /usr/share/fonts/cjkunifonts-ukai
W: cjkunifonts-ukai obsolete-not-provided ttfonts-zh_CN
W: cjkunifonts-ukai obsolete-not-provided ttfonts-zh_TW
W: cjkunifonts-uming symlink-should-be-relative
/etc/X11/fontpath.d/cjkunifonts-uming /usr/share/fonts/cjkunifonts-uming
W: cjkunifonts-uming obsolete-not-provided ttfonts-zh_CN
W: cjkunifonts-uming obsolete-not-provided ttfonts-zh_TW

IMO these can be waived.

+ package name follows upstream project name
+ spec filename matches package name
+ packages two Chinese truetype fonts currently part of fonts-chinese
+ Arphic Public License is listed on Licensing page
+ license with translations included
+ spec files is legible
+ source files agree with debian upstream:
465b1350911f086a2021c36e039f79c8  ttf-arphic-ukai_0.1.20060928.orig.tar.gz
4f2e5a4ba4cf3ac01518ea211a89fdc1  ttf-arphic-uming_0.1.20060928.orig.tar.gz
+ package is noarch and builds correctly
+ build deps listed
+ owns own dirs
+ filelist looks correct
+ consistent macro usage

Need attention:
- should not own ghostscript/conf.d/ which belongs to ghostscript
- /usr/share/fonts/zh_*/TrueType/ seem to be empty in the rpm's
- and already mentioned ghostscript conf paths

CID files had been updated. The symlinks shouldn't with 'ghost' to be loaded to
system from temp dir.

http://cchance.fedorapeople.org/20070829_cjkunifonts/cjkunifonts.spec
http://cchance.fedorapeople.org/20070829_cjkunifonts/cjkunifonts-0.1.20060928-2.fc8.src.rpm

Created attachment 180241 [details]
cjkunifonts.spec-5.patch

The changelog entries for each revision should document the changes too:

- drop requires for scriptlets
- %{cidmapdir} is owned by ghostscript

(The package is looking good now.  I think we're nearly there.:)

http://cchance.fedorapeople.org/20070829_cjkunifonts/cjkunifonts.spec
http://cchance.fedorapeople.org/20070829_cjkunifonts/cjkunifonts-0.1.20060928-3.fc8.src.rpm

Thanks, Caius!

Looks good to me now. :)

Package is APPROVED.

New Package CVS Request
=======================
Package Name: cjkunifonts
Short Description: Chinese TrueType Fonts.
Owners: cchance
Branches: devel
InitialCC: cchance
Cvsextras Commits: cchance

better:

New Package CVS Request
=======================
Package Name: cjkunifonts
Short Description: Chinese TrueType Fonts
Owners: cchance
Branches: devel
InitialCC: 
Cvsextras Commits: yes

cvsadmin done.

You can import the srpm now with common/cvs-import.sh.

cjkunifonts-0.1.20060928-4.fc8 imported and built by Caius.

Requested Fedora 10 tree for renamed package 'cjkuni-fonts' according to new font packaging guidelines.

[engineering.redhat.com #34002] AutoReply: New package tree on Fedora 11: cjkuni-fonts

New Package CVS Request
=======================
Package Name: cjkuni-fonts
Short Description: Chinese, Japanese, Korean Unicode TrueType fonts.
Owners: cchance
Branches: devel
InitialCC: fonts-sig

fedora-review+ ⇒ will review the cjkunifonts changes anyway and it's easier for me if they're done directly with the new srpm name in the new srpm component before the review (and not the reverse)

Nicolas, then better to open new review bugs IMHO than reopening old reviews for this?

I don't know, the whole renaming process is under-formalised. Ask nirik

ok, so this is a rename of an existing font? 

I can't seem to get to any of the above spec urls... 

If this package correctly obsoletes the old package, I can make the new package and you can follow the end of life procedure on the old package.

http://fedorapeople.org/~cchance/packages/cjkuni-fonts/cjkuni-fonts.spec

http://fedorapeople.org/~cchance/packages/cjkuni-fonts/cjkuni-fonts-0.2.20080216.1-16.fc11.src.rpm

(In reply to comment #41)
> ok, so this is a rename of an existing font? 

Yep, new package required for rename under new fonts packaging guidelines.

cvs admin done

Caius please import and build new package there so that Nicolas can review it.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1070407

http://koji.fedoraproject.org/koji/buildinfo?buildID=79605

http://koji.fedoraproject.org/koji/buildinfo?buildID=79716