Bug 253858

Summary:	Review Request: system-config-vsftpd - graphical utility for administrating vsftpd
Product:	[Fedora] Fedora	Reporter:	Maros Barabas <mbarabas>
Component:	Package Review	Assignee:	Maros Barabas <mbarabas>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	mmaslano: fedora-review+ wtogami: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-09-06 13:47:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Maros Barabas 2007-08-22 13:31:24 UTC

Spec URL: http://vsftpd-config.svn.sourceforge.net/viewvc/*checkout*/vsftpd-config/trunk/system-config-vsftpd.spec
SRPM URL: http://easynews.dl.sourceforge.net/sourceforge/vsftpd-config/system-config-vsftpd-0.4.4-1.fc7.src.rpm
Description: System-config-vsftpd is a graphical utility for administrating
Very Secure FTP Daemon ( VSFTPD ).
This is my first package and I need a sponsor.

Comment 1 Marcela Mašláňová 2007-08-28 09:39:15 UTC

You should fix this warning: File listed twice:
/usr/share/applications/system-config-vsftpd.desktop, because the file shouldn't
be listed twice.

rpmlint output:
W: system-config-vsftpd no-dependency-on usermode
W: system-config-vsftpd dangerous-command-in-%preun rm

another spec things:
The license could be GPLv2+ ?

%defattr(-,root,root) is usually %defattr(-,root,root,-)

I'm not sure if vendor couldn't be fedora. You are upstream so you can decide it.

Comment 2 Maros Barabas 2007-08-28 12:59:16 UTC

All done:
SPEC:
http://vsftpd-config.svn.sourceforge.net/viewvc/*checkout*/vsftpd-config/trunk/system-config-vsftpd.spec
RPM - for download use:
www.sf.net/projects/vsftpd-config/download

Thanks

Comment 3 Maros Barabas 2007-08-29 11:29:12 UTC

New Package CVS Request
=======================
Package Name: system-config-vsftpd
Short Description: graphical utility for administrating VSFTPD
Owners: mbarabas
Branches: FC-6 F-7
InitialCC: 
Cvsextras Commits: no

Comment 5 Bill Nottingham 2007-08-29 15:58:00 UTC

Random comments:

- it crashes when you don't have vsftpd installed

- any line of the sort:

    syslog = commands.getoutput( 'cat /var/log/messages''* | grep vsftpd' )

seems *very wrong*

- help->about doesn't do anything

Comment 6 Maros Barabas 2007-09-06 13:13:06 UTC

- (In reply to comment #5)
> Random comments:
> 
> - it crashes when you don't have vsftpd installed
looking for way how to check, if vsftpd is installed (whithout using rpm - other
systems).

> - any line of the sort:
> 
>     syslog = commands.getoutput( 'cat /var/log/messages''* | grep vsftpd' )
> 
> seems *very wrong*
you're right .. this is very wrong solution. Looking for some third party log
parser.

> - help->about doesn't do anything
done.