Bug 25386

Summary: [patch] viewing attached images doesn't work
Product: [Retired] Red Hat Linux Reporter: Tim Waugh <twaugh>
Component: pineAssignee: Mike A. Harris <mharris>
Status: CLOSED RAWHIDE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.1   
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard: Florence RC-1
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-02-03 11:34:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
pine-4.32-tmp.patch none

Description Tim Waugh 2001-01-31 16:38:19 UTC 
Viewing attached images in pine doesn't work: ee gets launched, but for
some reason the file it's told to look at has gone by the time it does.

The strace output suggests that the shell is exiting too early, but I
haven't investigated much yet, and was unable to reproduce the problem
outside of pine.
Comment 1 Tim Waugh 2001-01-31 16:49:56 UTC 
pine-4.31-2 works fine; pine-4.32-1 doesn't.
Comment 2 Tim Waugh 2001-01-31 18:41:09 UTC 
Created attachment 8581 [details]
pine-4.32-tmp.patch
Comment 3 Tim Waugh 2001-01-31 18:44:37 UTC 
The above patch is the correct fix, I think

Rationale: Pine is actually executing:

	sh -c '( cmd-read-from-mailcap tmpfile ; rm tmpfile ) &'

The new change in 4.32 was equivalent to this kind of thing:

  fork ( exec )
  wait4
+ unlink (tmpfile)

So tmpfile was disappearing because the (show file; rm file) process was
backgrounded and the shell returned, and in 4.32 it removes the file, needlessly
since the backgrounded task will do that when the viewer exits.
Comment 4 Glen Foster 2001-01-31 21:51:48 UTC 
This defect is considered MUST-FIX for Florence Release-Candidate #1
Comment 5 Tim Waugh 2001-02-03 11:34:46 UTC 
4.33 has this fix in.
Comment 6 Mike A. Harris 2001-02-06 16:28:43 UTC 
Yes, 4.33 has fixed this and will be in rawhide real soon.