Bug 253874
| Summary: | Review Request: lsdvd - Small application for displaying the contents of a DVD | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Saou <matthias> |
| Component: | Package Review | Assignee: | Ville Skyttä <ville.skytta> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kwizart, notting |
| Target Milestone: | --- | Flags: | ville.skytta:
fedora-review+
wtogami: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.16-5.fc7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-27 21:54:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matthias Saou
2007-08-22 15:30:19 UTC
Good review ticket for someone who needs to be sponsored. I'm afraid I'll ruin that joy for someone as I already did the review :P
- Could use %configure --disable-dependency-tracking but it doesn't make much
difference for a package this small.
- %description contains some info which is not relevant to end users, I would
shorten it to simply "lsdvd is an application for reading the contents of a DVD
and printing the list of contents to your terminal."
- Please bump release to 5%{?dist} to upgrade the NEVR of this package already
present in some 3rd party repositories.
All above comments can be addressed after import and before the first build, or
just ignored. Your choice, approved anyway.
Thanks Ville! You can check the updated spec file which I'll be importing in the same location as the previous one, and shout if anything's wrong with it ;-) New Package CVS Request ======================= Package Name: lsdvd Short Description: Small application for displaying the contents of a DVD Owners: matthias Branches: devel F-7 FC-6 InitialCC: Cvsextras Commits: yes The new specfile looks good, thanks. You missed one tiny detail though - "printing the contents of a DVD to your terminal" sounds scary to me, which is why I suggested "list of contents" :) (Applies to Summary too if you like the suggestion, BTW) Indeed, I had missed that, will fix, thanks! I think we get a little to speed for this! I little more investigation show that lsdvd isn't used by freevo since 1.7. Instead it uses python-kaa-metadata (which also orphan mmpython). kaa.metadata is already in Fedora... Futhermore lsdvd's sourceforge repository is now empty I think this is good to have it for compat with fc6 f7 And unless others apps are using it (do you you some example ?) I am for orphaning it... Usually apps can access lsdvd output by using kaa.metadata and should uses it instead... Yes, there are apps that use lsdvd. kaa-metadata is in Python, this is in plain C, they fit different scenarios. Python is an undesirably big dependency for trimmed down setups, but on the other hand apps written in Python almost certainly want to use a Python lib for this stuff. There's no indication that lsdvd's SF CVS has ever been anything but empty. Apples and oranges, what's the problem? ok sorry for the false positive then... i thought lsdvd was already orphaned So everything is fine...good! lsdvd-0.16-5.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. lsdvd-0.16-5.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |