Bug 253921
Summary: | GFS2: NULL superblock pointer causes panic after bad mount option | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Abhijith Das <adas> | ||||
Component: | kernel | Assignee: | Don Zickus <dzickus> | ||||
Status: | CLOSED ERRATA | QA Contact: | Dean Jansa <djansa> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | low | ||||||
Version: | 5.0 | CC: | adas, bmarzins, lwang, nstraz, swhiteho | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | RHBA-2007-0959 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-11-07 20:00:54 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 253289 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Comment 1
Nate Straz
2007-08-22 22:10:45 UTC
Created attachment 164441 [details]
check for NULL sdp in gfs2_kill_sb
This patch should fix the problem. Basically, when you try to mount gfs2 with
-o garbage, the mount fails and the gfs2 superblock is deallocated and becomes
NULL. The vfs comes around later on and calls gfs2_kill_sb. At this point the
hidden gfs2 superblock pointer (sb->s_fs_info) is NULL and dereferencing it
through gfs2_meta_syncfs causes the panic. (the other function call to
gfs2_delete_debugfs_file() succeeds because this function already checks for a
NULL pointer)
Tested and verified against kernel-2.6.18-43.gfs2abhi.001. Changing summary so that it's not confused with other bug #253289 Posted fix to rhkernel-list: http://post-office.corp.redhat.com/archives/rhkernel-list/2007-August/msg00826.html in 2.6.18-44.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0959.html |