Bug 254088

Summary: Review Request: b43-fwcutter - firmware cutter which outputs new format used by b43 drivers
Product: [Fedora] Fedora Reporter: John W. Linville <linville>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dwmw2, fedora-package-review, notting
Target Milestone: ---Flags: adel.gadllah: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 008-1.fc7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-09-04 22:08:48 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description John W. Linville 2007-08-24 02:04:54 UTC
Spec URL: http://linville.fedorapeople.org/b43-fwcutter.spec
SRPM URL: http://linville.fedorapeople.org/b43-fwcutter-008-1.fc7.src.rpm
Description: 

This package contains the 'b43-fwcutter' tool which is used to
extract firmware for the Broadcom network devices.

See the README.Fedora file shipped in the package's documentation for
instructions on using this tool.

Comment 1 John W. Linville 2007-08-24 02:08:48 UTC
The spec is basically a cut & paste of the bcm43xx-fwcutter package.

A new package is needed due to the different output format.  With both the 
existing bcm43xx-fwcutter and the new b43-fwcutter packages, one can still 
produce firmware for either the new b43/b43legacy drivers or the old 
bcm43xx/bcm43xx-mac80211 drivers.

Comment 2 Adel Gadllah 2007-08-25 19:33:23 UTC
Package Review:
===============
* md5sum matches upstream: 3f7fbf4f8dcd296c6d1b0d42eab0f9ac -> OK
---------------
* rpmlint output: none -> OK
---------------
* Package is named correctly -> OK
---------------
* uses macros consistently -> OK
---------------
* uses disttag -> OK
---------------
* License field is correct -> OK
---------------
* License is ok to ship and file is included -> OK
---------------
* BuildRequires are correct -> OK
---------------
* Ownership is set correctly -> OK
---------------
* scriplets are ok -> N/A
---------------
* buildroot is correct -> OK
---------------
* clean is present -> OK
---------------
* use $RPM_OPT_FLAGS -> ok
---------------
* desktop file installed correctly -> N/A
---------------
* file permissions are appropriate -> OK
---------------
* %docs are not needed for the package to work -> OK
---------------
* no devel package -> OK
---------------
* builds in mock -> OK
---------------
* no rpaths -> OK
===============
=> APPROVED
===============

---------------
NOTES:
Please add:
Obsoletes: bcm43xx-fwcutter 


Comment 3 Ville Skyttä 2007-08-26 21:14:48 UTC
(In reply to comment #2)
> NOTES:
> Please add:
> Obsoletes: bcm43xx-fwcutter 

Based on comment 1, sounds like bcm43xx-fwcutter serves a different purpose and
will stay -> the Obsoletes would be incorrect.

Comment 4 John W. Linville 2007-08-27 19:42:56 UTC
New Package CVS Request
=======================
Package Name: b43-fwcutter
Short Description: Firmware extraction tool for Broadcom wireless drivers
Owners: linville
Branches: F-7
InitialCC: /dev/null
Cvsextras Commits: no

Comment 5 Kevin Fenzi 2007-08-28 04:27:53 UTC
cvs done.

Comment 6 Fedora Update System 2007-08-29 17:26:20 UTC
b43-fwcutter-008-1.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2007-09-04 22:08:46 UTC
b43-fwcutter-008-1.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.