Bug 254142
| Summary: | Review Request: OpenSER - Open Source SIP Server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | Jan ONDREJ <ondrejj> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jeff, kevin, notting, ondrejj |
| Target Milestone: | --- | Flags: | ondrejj:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.3.0-1.fc7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-12-28 17:12:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Lemenkov
2007-08-24 13:30:00 UTC
Actually it's still in work-in-progress stage (I want to better modularize it), but almost ready. New version - 1.2.2-4 http://peter.fedorapeople.org/openser.spec http://peter.fedorapeople.org/openser-1.2.2-4.fc7.src.rpm %changelog * Sun Aug 26 2007 Peter Lemenkov <lemenkov> 1.2.2-4 - Introduced acc and acc_radius modules (Jan Ondrej) - Dropped radius_accounting condition * Sat Aug 25 2007 Peter Lemenkov <lemenkov> 1.2.2-3 - Changed license according to Fedora's policy - Make rpmlint more silent * Fri Aug 24 2007 Jan ONDREJ (SAL) <ondrejj(at)salstar.sk> 1.2.2-2 - added openser.init script - removed Patch0: openser--Makefile.diff and updated build section - spec file is 80 characters wide - added radius_accounting condition New rev. - 1.2.2-6 http://peter.fedorapeople.org/openser.spec http://peter.fedorapeople.org/openser-1.2.2-6.fc7.src.rpm %changelog * Sun Aug 26 2007 Jan ONDREJ (SAL) <ondrejj(at)salstar.sk> 1.2.2-6 - Fedora Core 6 build updates - changed attributes for openser.init to be rpmlint more silent * Sun Aug 26 2007 Peter Lemenkov <lemenkov> 1.2.2-5 - fixed paths for openssl libs and includes Package Review:
Use parallel make
- Support parallel make when possible (check the section
"Parallel make" of
http://fedoraproject.org/wiki/Packaging/Guidelines )
You can try to add %{?_smp_mflags} to make parameters.
May be "install -p" need to be used to preserve init script modification time.
I think you can remove commented requires.
New spec an rpm:
http://www.salstar.sk/pub/fedora/SPECS/openser.spec
http://www.salstar.sk/pub/fedora/SRPMS/7/openser-1.2.2-7.fc7.src.rpm
Thanks for additions. One more thing - missing BuildRequire: which http://peter.fedorapeople.org/openser.spec http://peter.fedorapeople.org/openser-1.2.2-8.fc7.src.rpm "which" does not needed to be in buildrequires, see: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions All documentation files need to be in UTF-8. More updates from changelog: - added reload section to init script this is needed by rpmlint - init script specified with initrddir macro http://fedoraproject.org/wiki/Packaging/RPMMacros - documentation converted to UTF-8 guidelines: - MUST: All filenames in rpm packages must be valid UTF-8. - added doc macro for documentation - documentation moved do proper place (/usr/share/doc/NAME-VERSION/) - unixodbc subpackage summary update (word order changed to start with upper case letter) http://www.salstar.sk/pub/fedora/SRPMS/7/openser-1.2.2-9.fc7.src.rpm I see only one thing left. Perl subpackage need to be in perl5/site... directory or not? New prerelease snapshot - 1.3.0pre1 http://peter.fedorapeople.org/openser.spec http://peter.fedorapeople.org/openser-1.3.0-0.1.pre1.fc7.src.rpm Final ver. 1.3.0 http://peter.fedorapeople.org/openser.spec http://peter.fedorapeople.org/openser-1.3.0-1.fc7.src.rpm Just this warning displayed by rpmlint on all packages. openser.i386: W: service-default-enabled /etc/rc.d/init.d/openser This warning can be ignored, anybody who installs openser want use it. :-) APPROVED Peter: Can you add me to package owners? If you've reviewed this, please assign it to yourself. OK, assigned to me. New Package CVS Request ======================= Package Name: openser Short Description: Open Source SIP Server Owners: peter,ondrejj Branches: F-7 F-8 EL-4 EL-5 Cvsextras Commits: yes Do you know, that this package does not build on EL-4? ERROR: Bad build req: No Package Found for radiusclient-ng-devel. Exiting. PS: see icq :) Peter: Do you still want the EL-4 branch, given comment #13? Peter's answer: yes I know - I'll ping maintainer of radiusclient-ng to create EL-4 branch for it cvs done. openser-1.3.0-1.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update openser' openser-1.3.0-1.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update openser' openser-1.3.0-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. openser-1.3.0-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |