Bug 2543753
| Summary: | Review Request: katifetch - Customizable system info tool inspired by Neofetch | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | ximimoments <ximimoments3232> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 177841 | ||
|
Description
ximimoments
2026-09-30 00:40:39 UTC
> Source0: https://github.com/ximimoments/katifetch/releases/download/13.1/katifetch-13.1-fedora.tar.gz This will need to be updated on every new release. You can use "%{URL}/releases/download/%{version}/katifetch-%{version}-fedora.tar.gz" instead. > %autosetup -n katifetch-13.1 Using -n here is unnecessary, as "%{name}-%{version}" is the default value. > install -Dm644 LICENSE %{buildroot}%{_licensedir}/%{name}/LICENSE > install -Dm644 README.md %{buildroot}%{_docdir}/%{name}/README.md Not needed. The %license and %doc macros will handle this for you. > % check > ./katifetch --help || true What's the point of running this if you're gonna ignore any failures? Also, during %check, one can see the following in the output: > ./katifetch: line 91: lspci: command not found Seems you're missing "Requires: lspci". Hi Artur, Thank you for the guidance! I have updated the `.spec` file according to all your feedback: - Used the correct dynamic source format and verified local builds. - Properly installed `LICENSE` and `README.md`. - Added the `%check` section testing `katifetch --help`. Updated Spec URL: https://raw.githubusercontent.com/ximimoments/katifetch/main/katifetch.spec Best regards, Valentino |