Bug 2545833
| Summary: | Review Request: python-frontmatter - Parse and manage posts with YAML (or other) frontmatter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Clement Verna <clems.verna> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Clement Verna
2026-10-05 08:32:56 UTC
Filed an upstream issue for dropping the uv-build version upper limit https://github.com/eyeseast/python-frontmatter/issues/142 This is an informal review (I'm not a packager yet, so I can't approve).
I rebuilt the SRPM in a Fedora rawhide container (rpmbuild --rebuild, with the
dynamic BuildRequires resolved) and ran rpmlint.
Good:
- Source0 matches upstream: sha256 c123bd29...283e9 for the v1.3.0 GitHub archive
- Build OK on rawhide (Python 3.15); %check: 47 passed, 7 deselected
- rpmlint: 0 errors, 0 warnings
- License: MIT matches upstream; LICENSE is in the dist-info and marked
%license (via %pyproject_save_files -l)
- Runtime Requires is only python3dist(pyyaml), as upstream declares
- The TOML deselects make sense: python3-toml is not in rawhide, so
TOMLHandler is None; the comment explains it well
Suggestions (none of them block):
1. frontmatter/conftest.py ends up in site-packages. It is a pytest fixture
for upstream's doctests and imports pytest, so it is not useful at runtime.
You could remove it after %pyproject_install, before %pyproject_save_files:
rm %{buildroot}%{python3_sitelib}/frontmatter/conftest.py
(or ask upstream to exclude it from the wheel).
2. The %prep comment says "Fedora ships 0.12.x only"; rawhide now has
python3-uv-build 0.13.6. The drop_upper patch is still needed (upstream
pins <0.12); only the version in the comment is out of date.
Looks good to me otherwise.
|