Bug 2546230
| Summary: | Review Request: bulky - Lightweight Bulk File Renamer with Nemo Integration | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | niohiani <notinsideofhereiamnotinside> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, package-review, terjeros |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
niohiani
2026-10-05 23:37:06 UTC
> mkdir -p %{buildroot}/usr/lib/bulky > mkdir -p %{buildroot}/usr/share/bulky > mkdir -p %{buildroot}/usr/share/applications > mkdir -p %{buildroot}/usr/share/doc/%{name}-%{version} > mkdir -p %{buildroot}/usr/share/icons/hicolor/scalable/apps > mkdir -p %{buildroot}/usr/bin > mkdir -p %{buildroot}/usr/share/glib-2.0/schemas > cp usr/share/applications/bulky.desktop %{buildroot}/usr/share/applications/ > cp usr/bin/bulky %{buildroot}/usr/bin/ > cp usr/lib/bulky/bulky.py %{buildroot}/usr/lib/bulky/ > cp usr/share/bulky/* %{buildroot}/usr/share/bulky > cp usr/share/glib-2.0/schemas/* %{buildroot}/usr/share/glib-2.0/schemas > cp usr/share/icons/hicolor/scalable/apps/* %{buildroot}/usr/share/icons/hicolor/scalable/apps a) Using -D option to install command this can shorter, please use macros too, like this: install -m 0755 -D usr/bin/bulky %{buildroot}%{_bindir}/bulky b) These extensive use of %{name} don't help readability imho. This: https://fastly.linuxmint.io/pool/main/b/%{name} makes it just hard to lookup the url from spec file c) A license file is missing. d) Why is this present: BuildRequires: gettext e) sed is missing from buildreq. f) sort these lines Requires: bash Requires: python3 Requires: python3-gobject Requires: python3-setproctitle Requires: python3-file-magic Requires: python3-xapp Requires: python3-unidecode Requires: xapp-symbolic-icons g) fix changelog: > * Mon Oct 05 2026 Niohiani Add version and release * Mon Oct 05 2026 Niohiani - 4.2-5 > - Fifth revision of spec file (these revisions have largely been to address minor issues, such as missing version info in the about dialog, or cleaning up the spec itself). Make this more compact >* Fri Sep 25 2026 Niohiani >- Fourth revision of spec file. >* Thu Sep 17 2026 Niohiani >- Second build. These two don't carry info and can be removed > * Sun May 15 2022 Alan Flambard Should be * Sun May 15 2022 Alan Flambard - 4.2-1 - First build. h) > Summary: Linux Mint's very own bulk renaming utility, with working Nemo integration. Drop trailing . please consider language too. Thank you for reviewing, Terje! I'll do another revision as soon as possible. New Spec: https://download.copr.fedorainfracloud.org/results/niohiani/MiscellanyMarketPlace/fedora-rawhide-x86_64/11088258-bulky/bulky.spec New SRPM: https://download.copr.fedorainfracloud.org/results/niohiani/MiscellanyMarketPlace/fedora-rawhide-x86_64/11088258-bulky/bulky-4.2-6.fc46.src.rpm All suggestions and corrections implemented! Hope this iteration is up to par. > License: GPLv3 License tags should use the SPDX format. This should be "GPL-3.0-only". https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names > cp usr/lib/bulky/bulky.py %{buildroot}/usr/lib/bulky/ > cp usr/share/applications/bulky.desktop %{buildroot}/usr/share/applications/ > cp usr/share/bulky/* %{buildroot}/usr/share/bulky > cp usr/share/glib-2.0/schemas/* %{buildroot}/usr/share/glib-2.0/schemas > cp usr/share/icons/hicolor/scalable/apps/* %{buildroot}/usr/share/icons/hicolor/scalable/apps 1. Use "cp -p" to preserve file timestamps. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps 2. Use RPM macros instead of hard-coded paths. https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation > %files > %{_datadir}/icons/hicolor/scalable/apps/bulky.svg This necessitates "Requires: hicolor-icon-theme". > %files > %{_datadir}/bulky/*.ui > %{_prefix}/lib/bulky/*.py This will make the package own only the files inside the directories, but not the directories themselves. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership Will implement your changes and post a new spec + build ASAP. Sorry for delay. Intense work week. Thank you for the feedback, Artur :] Here you go Artur! Spec: https://download.copr.fedorainfracloud.org/results/niohiani/MiscellanyMarketPlace/fedora-rawhide-x86_64/11241140-bulky/bulky.spec SRPM: https://download.copr.fedorainfracloud.org/results/niohiani/MiscellanyMarketPlace/fedora-rawhide-x86_64/11241140-bulky/bulky-4.2-7.fc46.src.rpm Let me know what you think, at your leisure. |