Bug 25519

Summary: rpc.rstatd crashes on linux 2.4.0
Product: [Retired] Red Hat Linux Reporter: Urban Widmark <urban>
Component: rusersAssignee: Nalin Dahyabhai <nalin>
Status: CLOSED RAWHIDE QA Contact: David Lawrence <dkl>
Severity: high Docs Contact:
Priority: medium    
Version: 7.1CC: chrismcc
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard: Florence RC-1
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-02-02 22:57:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Urban Widmark 2001-02-01 21:03:00 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.76 [en] (X11; U; Linux 2.4.1-pre11 i686)


rpc.rstatd parses /proc/stat to find various system info. When doing so it
assumes that the data read will be in a certain format, and matches on
keywords.

If one keyword is missing it will segfault. Linux 2.4 reports disk
information differently from 2.2 and rusers assumes 2.2 format.

Reproducible: Always
Steps to Reproduce:
1. /etc/init.d/portmap start
2. /etc/init.d/rstatd
3. xmeter -load localhost -update 1
   (or some other tool for displaying rstatd stats)


I have a patch that modifies it to read 2.4 format too. Untested on 2.2.
Also, note that this patch has the same problem as the old code if the
format changes again.
	http://www.hojdpunkten.ac.se/054/rstatd-linux2.4.patch
This needs to be applied after the "jbj" patch in the rpm.

Comment 1 Glen Foster 2001-02-02 22:57:17 UTC
We (Red Hat) should really fix this before next release

Comment 2 Nalin Dahyabhai 2001-02-06 21:15:51 UTC
This will be fixed in rusers-0.17-9 (with a more minimalistic patch -- if it
changes again, I'll probably switch it to using regex as your patch does). 
Thanks!