Bug 2554824

The project includes some files generated by wxGlade. WxGlade itself is licensed under MIT.
The generated files don't contain license tags.
So it isn't clear to me under which license those generated files are distributed.
Also MIT or Public Domain?

The gnumed-common package contains empty /run/gnumed-client.pid which looks unexpected.
Perhaps this should be a ghost file?

Also, this package installs /usr/share/gnumed/Gnumed/__init__.py.
Shouldn't that go under /usr/lib/python.../site-packages/ ... ?

The gnumed-client-de package installs /usr/bin/gm-install_arriba which is for downloading some java software?
Is this deliberate?

The naming of its man page looks off, since it contains an asterisk:

/usr/share/man/man8/gm-install_arriba.8*.gz

Similar issue with the manpages in the client package:

/usr/share/man/man1/gm-convert_file.1*.gz
/usr/share/man/man1/gm-create_datamatrix.1*.gz
/usr/share/man/man1/gm-describe_file.1*.gz
/usr/share/man/man1/gm-import_incoming.1*.gz
/usr/share/man/man1/gm-print_doc.1*.gz
/usr/share/man/man1/gm_ctl_client.1*.gz
/usr/share/man/man1/gnumed.1*.gz


Also there the question is why all the python code is installed under /usr/share/gnumed/Gnumed/ and not the standard site-packages directory.
Is this covered by fedora's python packaging guidelines?

With the bundled timelinelib the question is whether it's a genuine fork or just a vendored upstream copy.


fedora-review complains about:

gnumed-common.noarch: E: zero-length /run/gnumed-client.pid
gnumed-common.noarch: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/gnumed-client.tmpfiles.d.conf
gnumed-common.noarch: W: only-non-binary-in-usr-lib
gnumed-client.noarch: E: non-executable-script /usr/share/gnumed/Gnumed/gnumed.py 644 /usr/bin/env python3
gnumed-common.noarch: W: no-documentation
gnumed-common.noarch: E: incorrect-fsf-address /usr/share/licenses/gnumed-common/GnuPublicLicense.txt


Unfortunately, I cannot install the package on recent Fedora, due to orphaned packages gnumed-client depends on:

https://src.fedoraproject.org/rpms/python-hl7
python3-gnuplot (unclear what provided that exactly)

Another dependency nothing provides:
postgresql-client

(In reply to Georg Sauthoff from comment #1)
> The project includes some files generated by wxGlade. WxGlade itself is
> licensed under MIT.

Thanks will add this.

> The generated files don't contain license tags.
> So it isn't clear to me under which license those generated files are
> distributed.
> Also MIT or Public Domain?

Will check.

> 
> The gnumed-common package contains empty /run/gnumed-client.pid which looks
> unexpected.
> Perhaps this should be a ghost file?

Will make it a ghost file.

> 
> Also, this package installs /usr/share/gnumed/Gnumed/__init__.py.
> Shouldn't that go under /usr/lib/python.../site-packages/ ... ?

Will check if upstream could put it on PyPI and use standard paths.

> 
> The gnumed-client-de package installs /usr/bin/gm-install_arriba which is
> for downloading some java software?
> Is this deliberate?

Will check with upstream.

> 
> The naming of its man page looks off, since it contains an asterisk:
> 
> /usr/share/man/man8/gm-install_arriba.8*.gz
> 
> Similar issue with the manpages in the client package:
> 
> /usr/share/man/man1/gm-convert_file.1*.gz
> /usr/share/man/man1/gm-create_datamatrix.1*.gz
> /usr/share/man/man1/gm-describe_file.1*.gz
> /usr/share/man/man1/gm-import_incoming.1*.gz
> /usr/share/man/man1/gm-print_doc.1*.gz
> /usr/share/man/man1/gm_ctl_client.1*.gz
> /usr/share/man/man1/gnumed.1*.gz
> 

Will fix these. Thanks.

> 
> Also there the question is why all the python code is installed under
> /usr/share/gnumed/Gnumed/ and not the standard site-packages directory.
> Is this covered by fedora's python packaging guidelines?
> 
> With the bundled timelinelib the question is whether it's a genuine fork or
> just a vendored upstream copy.

Will check if a upstream copy will work.

> 
> 
> fedora-review complains about:
> 
> gnumed-common.noarch: E: zero-length /run/gnumed-client.pid
> gnumed-common.noarch: W: post-without-tmpfile-creation
> /usr/lib/tmpfiles.d/gnumed-client.tmpfiles.d.conf
> gnumed-common.noarch: W: only-non-binary-in-usr-lib
> gnumed-client.noarch: E: non-executable-script
> /usr/share/gnumed/Gnumed/gnumed.py 644 /usr/bin/env python3

Will check this after finding out if standard python directories can be used.

> gnumed-common.noarch: W: no-documentation
> gnumed-common.noarch: E: incorrect-fsf-address
> /usr/share/licenses/gnumed-common/GnuPublicLicense.txt

Patch submitted upstream for the license:
https://github.com/ncqgm/gnumed/pull/53

> 
> 
> Unfortunately, I cannot install the package on recent Fedora, due to
> orphaned packages gnumed-client depends on:
> 
> https://src.fedoraproject.org/rpms/python-hl7

Opened a review request to unretire

> python3-gnuplot (unclear what provided that exactly)

This should just be gnuplot, will update the spec file.

> 
> Another dependency nothing provides:
> postgresql-client

This should be the Fedora postgres package, will update the spec file.