Bug 2555050

- Are the binaries built when devtools is enabled required at all?
- Upstream sets multiple LDFLAGS, have you checked if they're required? https://github.com/jesseduffield/lazygit/blob/master/.goreleaser.yml#L18
- No need to add the TestIntegration block, but this is just a proposal.

(In reply to Mikel Olasagasti Uranga from comment #1)
> - Are the binaries built when devtools is enabled required at all?

AFAIK, no. The pre-build binary at https://github.com/jesseduffield/lazygit/releases/download/v0.66.2/lazygit_0.66.2_linux_x86_64.tar.gz is distibuted without these devtools binaries.

> - Upstream sets multiple LDFLAGS, have you checked if they're required?
> https://github.com/jesseduffield/lazygit/blob/master/.goreleaser.yml#L18

Beside some automated checks for updates, `lazygit -v` uses it to print something like this
commit=63ab89fff478854deb4a35ef8902676b3cc5ca72, build date=2026-10-16T09:27:30Z, build source=binaryRelease, version=0.66.2, os=linux, arch=amd64, git version=2.56.0

I added these LDFLAGS as well. I undestand that you weren't asking about the -s and -w flags which I believe would remove debug info. More info at https://pkg.go.dev/cmd/link

> - No need to add the TestIntegration block, but this is just a proposal.

Done.


FYI, I updated the original spec file.

[fedora-review-service-build]

> > - Are the binaries built when devtools is enabled required at all?
> 
> AFAIK, no. The pre-build binary at
> https://github.com/jesseduffield/lazygit/releases/download/v0.66.2/lazygit_0.
> 66.2_linux_x86_64.tar.gz is distibuted without these devtools binaries.

Then I think it's best to remove them. 

> > - Upstream sets multiple LDFLAGS, have you checked if they're required?
> > https://github.com/jesseduffield/lazygit/blob/master/.goreleaser.yml#L18
> 
> Beside some automated checks for updates, `lazygit -v` uses it to print
> something like this
> commit=63ab89fff478854deb4a35ef8902676b3cc5ca72, build
> date=2026-10-16T09:27:30Z, build source=binaryRelease, version=0.66.2,
> os=linux, arch=amd64, git version=2.56.0
> 
> I added these LDFLAGS as well. I undestand that you weren't asking about the
> -s and -w flags which I believe would remove debug info. More info at
> https://pkg.go.dev/cmd/link

Correct, I meant for those that -v show. If you want to use packit the "commit" var can be a problem, so maybe you can set it to Fedora also.

># Fix licensing of github.com/kr/logfmt
> Patch0:         https://github.com/jesseduffield/lazygit/pull/6142.patch

The patch might not needed for Fedora. You can use an override to update kr/logfmt to commit 19f9bcb100e6bcb308b5db29c682de01e9b3f2e6

Try with adding the following to go-vendor-tools.toml

[archive.dependency_overrides]
"github.com/kr/logfmt" = "19f9bcb100e6"

For upstream you should only update go.mod/go.sum and let "go vendor" do the update of dependencies.

(In reply to Mikel Olasagasti Uranga from comment #3)
> > > - Are the binaries built when devtools is enabled required at all?
> > 
> > AFAIK, no. The pre-build binary at
> > https://github.com/jesseduffield/lazygit/releases/download/v0.66.2/lazygit_0.
> > 66.2_linux_x86_64.tar.gz is distibuted without these devtools binaries.
> 
> Then I think it's best to remove them. 

Done.

> > > - Upstream sets multiple LDFLAGS, have you checked if they're required?
> > > https://github.com/jesseduffield/lazygit/blob/master/.goreleaser.yml#L18
> > 
> > Beside some automated checks for updates, `lazygit -v` uses it to print
> > something like this
> > commit=63ab89fff478854deb4a35ef8902676b3cc5ca72, build
> > date=2026-10-16T09:27:30Z, build source=binaryRelease, version=0.66.2,
> > os=linux, arch=amd64, git version=2.56.0
> > 
> > I added these LDFLAGS as well. I undestand that you weren't asking about the
> > -s and -w flags which I believe would remove debug info. More info at
> > https://pkg.go.dev/cmd/link
> 
> Correct, I meant for those that -v show. If you want to use packit the
> "commit" var can be a problem, so maybe you can set it to Fedora also.

I set it to "unspecified".

> ># Fix licensing of github.com/kr/logfmt
> > Patch0:         https://github.com/jesseduffield/lazygit/pull/6142.patch
> 
> The patch might not needed for Fedora. You can use an override to update
> kr/logfmt to commit 19f9bcb100e6bcb308b5db29c682de01e9b3f2e6
> 
> Try with adding the following to go-vendor-tools.toml
> 
> [archive.dependency_overrides]
> "github.com/kr/logfmt" = "19f9bcb100e6"
> 
> For upstream you should only update go.mod/go.sum and let "go vendor" do the
> update of dependencies.

Done.


FYI, I updated the original spec file.

[fedora-review-service-build]

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/lazygit
Monitoring:
Anitya project is accessible by this link 
`https://release-monitoring.org/project/268930`
 you can modify it manually.
Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.

FEDORA-2026-9a729527e7 (lazygit-0.66.2-1.fc46) has been submitted as an update to Fedora 46.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-9a729527e7

FEDORA-2026-9a729527e7 (lazygit-0.66.2-1.fc46) has been pushed to the Fedora 46 stable repository.
If problem still persists, please make note of it in this bug report.

> Package approved! On import, don't forget to do the following:
> 
> - [x] Add the package to release-monitoring.org
> - [x] Give go-sig privileges (at least commit) on the package
> - [x] Close the review bug by referencing its ID in the rpm changelog and
the Bodhi ticket.
> - [ ] Consider configuring Packit service to help with maintenance

Thank you for the review. I'll try with Packit on a next update.