Bug 255561

Summary:	Review Request: d3lphin - A file manager for KDE focusing on usability
Product:	[Fedora] Fedora	Reporter:	Chitlesh GOORAH <chitlesh>
Component:	Package Review	Assignee:	Johan Cwiklinski <fedora>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, fedora, notting
Target Milestone:	---	Flags:	fedora: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-08-28 15:28:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	248800

Description Chitlesh GOORAH 2007-08-26 23:33:16 UTC

Spec URL: http://chitlesh.fedorapeople.org/d3lphin/d3lphin.spec
SRPM URL: http://chitlesh.fedorapeople.org/d3lphin/d3lphin-0.9.2-2.fc7.src.rpm
Description:
D3lphin is a fork of dolphin, since the latter
is unmaintained for kde3.

D3lphin focuses on being only a file manager.
This approach allows to optimize the user
interface for the task of file management.

Comment 1 Johan Cwiklinski 2007-08-27 21:03:58 UTC

Review:
+ package builds in mock (x86_64).
+ rpmlint is silent for SRPM.
+ rpmlint is silent for RPMS : the dangling symlink warning is normal (provided
by kdebase).
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code Not contents.
+ no static libraries present.
+ no .pc files present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available, and proprely installed.
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ icon cache scriptlets used.
+ Desktop file handled correctly.
+ file permissions are appropriate.
+ GUI app, desktop file installed properly

APPROVED

Comment 2 Chitlesh GOORAH 2007-08-27 21:29:20 UTC

New Package CVS Request
=======================
Package Name: d3lphin
Short Description: A file manager for KDE focusing on usability
Owners: chitlesh
Branches: FC-6 F-7 devel

Comment 3 Kevin Fenzi 2007-08-28 04:21:44 UTC

cvs done.