Bug 255721
Summary: | Review Request: ruby-rrdtool - RRDtool module for Ruby | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
Component: | Package Review | Assignee: | S.A. Hartsuiker <s.a.hartsuiker> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, mtasaka, notting, opensource |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | bob:
fedora-review+
kevin: fedora-cvs+ |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-08-24 14:09:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jeroen van Meeuwen
2007-08-27 02:14:55 UTC
Please follow: http://fedoraproject.org/wiki/Packaging/Ruby There is something like this missing: Requires: ruby(abi) = 1.8 Name should be: ruby-RRDtool Seems you should use in the beginning of the spec: %{!?ruby_sitearch: %define ruby_sitearch %(ruby -rrbconfig -e 'puts Config::CONFIG["sitearchdir"]')} and %{ruby_sitearch} in %files A Provide ruby(LIBRARY) = VERSION line is missing. Maybe more, I just ran over the ruby guidelines. I'm happy to do the review as soon as the comments above have been addressed Any progress here? Looks like I need to pay more attention to My Front Page and tweak my mail filters ... Sorry guys. Right now, libssl is preventing me from running another build but I'll get back to this soon It may not be quite as quick but you can always do koji scratch builds to test your packages: koji build --scratch dist-f9 ruby-rrdtool-0.6.0-1.fc7.src.rpm Thanks for the tip but I still haven't been able to get it to actually work. I wanted to do that before I continued with the packaging but I'm unable to. Closing the review for now. I've found some time and addressed the issues stated above. New SRPM and SPEC are at: SPEC: http://www.kanarip.com/custom/SPECS/ruby-RRDtool.spec SRPM: http://www.kanarip.com/custom/el5/SRPMS/ruby-RRDtool-0.6.0-3.el5.src.rpm Builds in koji (and logs): dist-f8-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=744434 dist-f9-updates-candidate: http://koji.fedoraproject.org/koji/taskinfo?taskID=744439 dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=744453 Confirmed to be working at http://puppetmanaged.org/rrd/ghandalf.kanarip.com/ (for example) Mind that el5 doesn't need the patch and the el5.src.rpm does not build on f{8,9,10}. This SRPM does (same SPEC file): http://www.kanarip.com/custom/f10/SRPMS/ruby-RRDtool-0.6.0-3.fc10.src.rpm RPM Lint: just a warning about documentation Package name: ruby-RRDtool Spec file: ruby-RRDtool.spec License: MIT Actual License: MIT, but not included in rpm %doc License: not included Spec file language: english Spec file readable: yes Upstream source vs. used tarball: same Compile and Build: - F-8: builds - F-9: builds - rawhide: builds - EL-5: builds Applicable Package Guidelines: no documentation included Locales: not aplicable Shared libs: /usr/lib/ruby/site_ruby/1.8/`arch`-linux/RRDtool.so Relocatable: no Directory and file ownership: ok No duplicate files in %files: ok File Permissions: ok Macro usage: ok Code vs. Content: ok (Large) Documentation: no documentation %doc affecting runtime: not applicable Header files in -devel package: not applicable Static Libraries in -static package: not applicable pkgconfig Requires: Library files: RRDtool.so Devel requires base package: not applicable .la libtool archives: not applicable Duplicate ownership of files/directories: ok Remove BuildRoot: no explicitly removed UTF-8 filenames: none My only "problem" is the absence of the README file, as it contains the license Documentation now included: New SPEC: http://www.kanarip.com/custom/SPECS/ruby-RRDtool.spec New SRPM: http://www.kanarip.com/custom/f10/SRPMS/ruby-RRDtool-0.6.0-4.fc10.src.rpm Setting correct flag since review is ongoing (?) package approved would be (+) Documentation has been added thus problem fixed. package approved. Good Review sahartsu. New Package CVS Request ======================= Package Name: ruby-RRDtool Short Description: RRDtool lib for Ruby Owners: kanarip Branches: EL-5 F-8 F-9 devel InitialCC: kanarip Cvsextras Commits: yes Some notes: * On x86_64, %ruby_sitearch is /usr/lib64/ruby/site_ruby/1.8/x86_64-linux so This line -------------------------------------------------------------------- mkdir -p $RPM_BUILD_ROOT/%{_libdir}/ruby/site_ruby/1.8/i386-linux -------------------------------------------------------------------- is useless (and actually seems not needed as: http://koji.fedoraproject.org/koji/taskinfo?taskID=745638 * I see test/ subdirectory. If some tests are available, please consider to create %check section and execute some tests on that section. Fixed the mkdir Not going to rake test for the following reasons: - rubygem-hoe, needed for tests, is not available in EL-5. - it fails anyway as it seems to be unmaintained code, we can try and solve it after the review finishes as it is not a packaging issue. Some minor issues: - The URL appears to be wrong, it's just pointing to the top of rubyforge. - can you use %{?_smp_mflags} on your make here? Applied the cosmetic fixes to the spec at: http://www.kanarip.com/custom/SPECS/ruby-RRDtool.spec If you need me to rebuild and submit here let me know. cvs done. Just out of curiosity, whats the difference between this package and rrdtool-ruby? Just different bindings? Perhaps the two projects could work together someday? Near as I can tell, after looking at this a bit, is that ruby-rrdtool is based upon work of the original author of rrdtool-ruby. Dear Hartsuiker: Keep the assignee to the reviewer, please ruby-RRDtool-0.6.0-6.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/ruby-RRDtool-0.6.0-6.fc9 ruby-RRDtool-0.6.0-6.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/ruby-RRDtool-0.6.0-6.fc8 ruby-RRDtool-0.6.0-6.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. ruby-RRDtool-0.6.0-6.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |