Bug 256521
| Summary: | Review Request: php-pear-Creole - A database abstraction layer for PHP5 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kahl <fedora> |
| Component: | Package Review | Assignee: | Remi Collet <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.1.0-5.fc7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-11 01:47:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 275211, 283401 | ||
| Bug Blocks: | |||
|
Description
Alexander Kahl
2007-08-27 14:22:57 UTC
Please, submit php-channel-phpdb to review and add it as a blocker for this review.
There is no Guidelines yet for "channel", we have to work on it.
- Please, don't use %{pear_phpdir}/* in %file
- keep version in php-pear BR (mainly to avoid EL-4 build)
I don't know about License for channel, but you could probably use the same
(LGPLv2) than the package provided by this channel or simply "Public domain"
(N/A is not a acceptable)
I could do a review, but i couldn't sponsor you.
- also change name to php-pear-creole (no uppercase in upstream package name) Thanks Remi for helping me!
- add php-channel-phpdb as a blocker: fixed
- change license field in the channel: fixed
- replace ${pear_phpdir} with ${_datadir}/pear: fixed
- keep version in php-pear BR: sorry, what does that mean?
- name change to php-pear-creole: fixed
New Spec URL:
http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/7/SPECS/php-pear-creole.spec
New SRPM URL:
http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/7/SRPMS/php-pear-creole-1.1.0-4.fc7.src.rpm
What can I do to improve my chances finding a sponsor?
You must use
BuildRequires: php-pear >= 1:1.4.9-1.2
Because macro used for this spec are not defined in previous pear release.
I will prefer R and BR on php-channel(pear.phpdb.org) rather then php-channel-phpdb.
Ok, there is no guidelines yet, but i will propose this
When i wrote don't use %{pear_phpdir}/*, i mean use %{pear_phpdir} but not *
Probably ${pear_phpdir}/creole
I can't build this RPM, don't understand why.
"pear install" hangs.
I will try later.
It seems there is a bug in PEAR. Build ok with F7 pear 1.5.0 Build hangs with newer version (1.5.4, 1.6.1). This issue also affects php-pear-PHPUnit. See Bug #283401 Updated Spec URL: http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/7/SPECS/php-pear-creole.spec Updated SRPM URL: http://prelive.iconmobile.com/dev31/fedora-icm-repo/Fedora/7/SRPMS/php-pear-creole-1.1.0-5.fc7.src.rpm Changes: - proper php-pear requirement - changed php-channel requirement syntax - rectified file ownership Shall I nail the pear version requirement to < 1.5.4? > Shall I nail the pear version requirement to < 1.5.4? No. Bug #283401 is closed (pear 1.6.2 pushed in rawhide) Any progress here? Is -5 OK? Have you been sponsored ? (In reply to comment #9) > Have you been sponsored ? > Now I am sponsoring Alexander (bug 275831) Remi, will you continue the review now? Yes. I will work on it this week-end. REVIEW:
* rpmlint :
W: no-documentation
* The package is named according to the Package Naming Guidelines.
* The spec file name match the base package
* The package meet the PHP Packaging Guidelines (see below)
* Fedora approved license (LGPLv2)
* License field in the package spec file match the actual license
* The spec file is written in American English
* The spec file is legible
* The sources used to build the package must match the upstream source
87480d20b83be9ae859153539ec57c70 creole-1.1.0.tgz
* build in mock (F-7, noarch)
* All build dependencies are listed in BuildRequires
* no locales
* no shared library files
* package own all directories that it creates
* Package don't own files or directories already owned by other packages
* no duplicate files
* Permissions on files are set properly
* %clean section
* package consistently use macros
* The package contain code
* no documentation
* no library
* no desktop file
* %install, start with rm -rf %{buildroot}
* All filenames are valid UTF-8
* scriptlets are sane*
* Final Provides ok
php-pear(pear.phpdb.org/creole) = 1.1.0
php-pear-creole = 1.1.0-5.fc8
* Final Requires
/usr/bin/pear
php-channel(pear.phpdb.org)
php-cli >= 5.0.0
php-pear
** No test suite or example to run.
There is actually no PHP Guidelines for non standard channel, but this spec
conforms with other RPM.
APPROVED
New Package CVS Request ======================= Package Name: php-pear-creole Short Description: A database abstraction layer for PHP5 Owners: akahl Branches: F-7 InitialCC: remi Cvsextras Commits: yes cvs done. Builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=189309 http://koji.fedoraproject.org/koji/taskinfo?taskID=189308 Successful. php-pear-creole-1.1.0-5.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |