Bug 2573217
| Summary: | Review Request: agent-skills - Markdown SKILLS.md files in /usr/share/agents/skills/ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Justin Wheeler <fedora> |
| Component: | Package Review | Assignee: | Miroslav Suchý <msuchy> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | carchen, cverna, davdunc, jwf, lbarczio, msuchy, package-review, ttomecek |
| Target Milestone: | --- | Flags: | msuchy:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Justin Wheeler
2026-11-13 16:07:30 UTC
The link to spec breaks fedora-review. Here is correct one: Spec URL: https://forge.fedoraproject.org/ai-ml/skills-library/raw/branch/main/agent-skills.spec SRPM URL: https://jflory7.fedorapeople.org/pub/rpms/agent-skills-0.2.0-1.fc45.src.rpm Blocking issue: * The package does not build. It fails with: install: creating directory '/builddir/build/BUILD/agent-skills-0.2.0-build/BUILDROOT/usr/share/agents/skills' + for skill in fedora-compose-triage fedora-ftbfs-search fedora-packaging fedora-twif-wordpress-export meeting-secretary packit-pull-from-upstream-onboarding + cp -a skills/fedora-compose-triage /builddir/build/BUILD/agent-skills-0.2.0-build/BUILDROOT/usr/share/agents/skills/fedora-compose-triage + for skill in fedora-compose-triage fedora-ftbfs-search fedora-packaging fedora-twif-wordpress-export meeting-secretary packit-pull-from-upstream-onboarding + cp -a skills/fedora-ftbfs-search /builddir/build/BUILD/agent-skills-0.2.0-build/BUILDROOT/usr/share/agents/skills/fedora-ftbfs-search + for skill in fedora-compose-triage fedora-ftbfs-search fedora-packaging fedora-twif-wordpress-export meeting-secretary packit-pull-from-upstream-onboarding + cp -a skills/fedora-packaging /builddir/build/BUILD/agent-skills-0.2.0-build/BUILDROOT/usr/share/agents/skills/fedora-packaging + for skill in fedora-compose-triage fedora-ftbfs-search fedora-packaging fedora-twif-wordpress-export meeting-secretary packit-pull-from-upstream-onboarding + cp -a skills/fedora-twif-wordpress-export /builddir/build/BUILD/agent-skills-0.2.0-build/BUILDROOT/usr/share/agents/skills/fedora-twif-wordpress-export cp: cannot stat 'skills/fedora-twif-wordpress-export': No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.LZthYH (%install) Few additional comments: - the license CC-BY-SA-4.0 is generally not-allowed, but is allowed for content only. This package is content only, so the license is ok. - I would personally use %autorelease and %autochangelog, but your style is ok too. - instead of %package -n agent-skill-fedora-compose-triage I would use %package fedora-compose-triage This creates subpackage agent-skill-fedora-compose-triage as well, but is concise. Otherwise LGTM, please correct the specfile so I can finish all checks. |