Bug 2573565

Summary: Review Request: python-darkdetect - Detect whether the desktop uses a dark theme
Product: [Fedora] Fedora Reporter: igor.rabbit99
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: clems.verna, package-review
Target Milestone: ---Flags: clems.verna: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841, 2573566, 2573567    

Description igor.rabbit99 2026-11-14 04:39:44 UTC
Spec URL: https://raw.githubusercontent.com/igorbispo99/ParrotIA/v1.4.0/packaging/fedora/python-darkdetect.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/igorbispopessoal/parrotia/srpm-builds/11324216/python-darkdetect-0.8.0-1.fc46.src.rpm

Description:
darkdetect reports whether the operating system is using a dark or light
theme, and can watch for changes. On Linux it reads the GNOME/GTK color
scheme setting; macOS and Windows are also supported.

Fedora Account System Username: igorbispopessoal

COPR build (fedora-44, fedora-45, rawhide x86_64):
https://copr.fedorainfracloud.org/coprs/igorbispopessoal/parrotia/build/11324216/

This is my first package and I need a sponsor. python-darkdetect is a
dependency of python-customtkinter, which ParrotIA (an AGPL-3.0-or-later
desktop/CLI transcription app that I maintain upstream) needs. The review
requests for python-customtkinter and parrotia follow.

Upstream ships no tests, so %check runs %pyproject_check_import with the
macOS- and Windows-only modules excluded. fedora-review and rpmlint report
no issues (0 errors, 0 warnings).

Comment 1 Clement Verna 2026-11-16 13:56:52 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Nothing blocking. Two non-blocking observations:
  - The two %check exclusions (darkdetect._mac_detect, darkdetect._windows_detect)
    are no-ops: %pyproject_check_import only imports the top-level package, and
    __init__.py already selects the platform module via sys.platform.
  - On Linux the theme is read by running /usr/bin/gsettings, but nothing pulls
    in glib2; when it is missing the exception is swallowed and theme() reports
    "Light". Consider Recommends: glib2.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "*No copyright*
     BSD 3-Clause License". 9 files have unknown license. Detailed output
     of licensecheck in /tmp/opencode/review-2573565/artifacts/review-
     python-darkdetect/licensecheck.txt
     Reviewer: LICENSE is the 3-clause BSD text and every source header says
     "Distributed under the terms of the 3-clause BSD License". The "unknown
     or generated" hits above are egg-info/PKG-INFO metadata, not code.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.15,
     /usr/lib/python3.15/site-packages
     Reviewer: /usr/lib/python3.15{,/site-packages} are owned by python3, this
     is the well-known false positive.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
     Reviewer: Release: %autorelease / %changelog %autochangelog (rpmautospec).
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 2549 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
     Reviewer: with the built RPM installed, "python3 -m darkdetect" prints
     "Current theme: Light" and theme()/isDark()/isLight() return sane
     values; the Light result is expected in a chroot with no session.
[x]: Latest version is packaged.
     Reviewer: 0.8.0 is the newest release on PyPI.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
     Reviewer: upstream has no test suite (no tests/ in the repo, none in the
     sdist), so the guideline fallback applies: %pyproject_check_import runs
     as the mandatory smoke test and passes (build log: "Check import:
     darkdetect").
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-darkdetect-0.8.0-1.fc46.noarch.rpm
          python-darkdetect-0.8.0-1.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp7w4y0cjt')]
checks: 32, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 1.5 s 


Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.10.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.4 s 


Source checksums
----------------
https://files.pythonhosted.org/packages/source/d/darkdetect/darkdetect-0.8.0.tar.gz :
  CHECKSUM(SHA256) this package     : b5428e1170263eb5dea44c25dc3895edd75e6f52300986353cd63533fe7df8b1
  CHECKSUM(SHA256) upstream package : b5428e1170263eb5dea44c25dc3895edd75e6f52300986353cd63533fe7df8b1


Requires
--------
python3-darkdetect (rpmlib, GLIBC filtered):
    python(abi)


Provides
--------
python3-darkdetect:
    python-darkdetect
    python3-darkdetect
    python3.15-darkdetect
    python3.15dist(darkdetect)
    python3dist(darkdetect)


Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18
Command line :/usr/sbin/fedora-review -n python-darkdetect -m fedora-rawhide-aarch64 -B
Buildroot used: fedora-rawhide-aarch64
Active plugins: Generic, Shell-api, Python
Disabled plugins: fonts, PHP, Perl, Java, Haskell, Ocaml, R, SugarActivity, C/C++
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT

Package approved.

Note: this is a first-time submission (bug blocks FE-NEEDSPONSOR); a sponsor
still has to take the packager through the sponsorship process before the
package can be imported.

Comment 2 igor.rabbit99 2026-11-16 15:05:55 UTC
Thank you for the review and the approval.

I applied both suggestions:
- Removed the no-op -e exclusions from %pyproject_check_import, with a comment noting that the platform detectors are private modules.
- Added Recommends: glib2, so gsettings is available and theme() doesn't silently fall back to Light.

Spec URL: https://raw.githubusercontent.com/igorbispo99/ParrotIA/v1.4.1/packaging/fedora/python-darkdetect.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/igorbispopessoal/parrotia/srpm-builds/11335702/python-darkdetect-0.8.0-1.fc46.src.rpm
Copr build (Fedora 44, 45 and Rawhide): https://copr.fedorainfracloud.org/coprs/build/11335702/