Bug 2573566
| Summary: | Review Request: python-customtkinter - Modern, customizable widgets for Tkinter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | igor.rabbit99 |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | clems.verna, package-review |
| Target Milestone: | --- | Flags: | clems.verna:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2573565 | ||
| Bug Blocks: | 2573567 | ||
|
Description
igor.rabbit99
2026-11-14 04:41:00 UTC
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- [!] Latest version is packaged: 5.2.2 is from 2024-01-10, 6.0.0 was released
2026-06-24. The 6.0.0 sdist has an identical layout (same MIT LICENSE, same
two Roboto faces, same glyph font, same dependencies, one new theme), so the
bump is a one-line Version: change and the %install symlink loop still
applies. If ParrotIA needs 5.2.2 specifically, please state that in the spec
or the bug.
- [!] Avoid bundling fonts in non-fonts packages: CustomTkinter_shapes_font.otf
is still shipped in a private directory and copied into ~/.fonts at import
time. Installing it into %{_fontdir} would satisfy the guideline; if it stays
private (a glyph-only font would otherwise appear in users' font menus),
record that rationale in the spec.
- Non-blocking notes:
- rpmlint's "python-leftover-require python3-tkinter" is a false positive:
python3-tkinter provides no python3dist(tkinter), so the explicit
Requires: python3-tkinter is needed.
- the two dangling-symlink warnings are expected inside the buildroot and
resolve once google-roboto-fonts is installed; I verified the runtime copy
of both faces and of the glyph font with the font package present.
- "no-documentation" is expected: the sdist ships no README or docs.
- consider Recommends: python3dist(pillow); CTkImage is the normal way to
show images but Pillow is not declared anywhere upstream, so users hit a
bare ImportError at first use.
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "MIT License", "*No copyright* Creative
Commons CC0 1.0 and/or MIT License", "*No copyright* MIT License". 57
files have unknown license. Detailed output of licensecheck in
/tmp/opencode/review-2573566/artifacts/review-python-
customtkinter/licensecheck.txt
Reviewer: LICENSE is MIT; setup.cfg/PKG-INFO carry a contradicting
"Creative Commons Zero v1.0 Universal" string, but upstream's own
classifier says MIT and the license text is authoritative. The removed
Roboto files were Apache-2.0 (Google, 2.137) and no Roboto bytes remain
in the binary RPM, so Apache-2.0 is correctly left out of License:.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.15/site-
packages, /usr/lib/python3.15
Reviewer: /usr/lib/python3.15{,/site-packages} are owned by python3, this
is the well-known false positive.
[x]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled(<libname>) if unbundling is not possible.
Reviewer: Roboto is unbundled via symlinks into google-roboto-fonts;
digest check of the removed files confirms Apache-2.0 Roboto 2.137,
Fedora ships 2.138 at the same paths.
[x]: Changelog in prescribed format.
Reviewer: Release: %autorelease / %changelog %autochangelog (rpmautospec).
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[!]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
Reviewer: the two Roboto faces are unbundled in %install and replaced by
symlinks to /usr/share/fonts/google-roboto/ (Requires: google-roboto-fonts),
which is the right thing to do. What remains is CustomTkinter_shapes_font.otf,
upstream's own glyph font, kept in a private directory and copied into
~/.fonts at import time. index.adoc says such fonts 'should always be
packaged in the system-wide font repositories instead of private
application directories', so this is a SHOULD-level deviation; either
install the OTF into %{_fontdir} (and adjust the loader) or record the
rationale in the spec.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
Reviewer: import customtkinter succeeds headless and the fonts are
copied into ~/.fonts as upstream intends; widget rendering itself was
not exercised (no X server in the build environment).
[!]: Latest version is packaged.
Reviewer: 5.2.2 is from 2024-01-10; 6.0.0 was released 2026-06-24. The
6.0.0 sdist has the identical layout (same MIT LICENSE, same two Roboto
faces, same glyph font, same dependencies), so the bump is a one-line
change and the %install symlink loop needs no edits.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
Reviewer: upstream's test/ directory is not in the sdist and contains
manual GUI scripts (CTk() windows + sleeps, no asserts, no pytest/tox),
so they cannot be automated; an import smoke test is the reasonable
fallback. Worth a comment in the spec next to %check.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-customtkinter-5.2.2-1.fc46.noarch.rpm
python-customtkinter-5.2.2-1.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
/usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmprf5p87d3')]
checks: 32, packages: 2
python3-customtkinter.noarch: W: python-leftover-require python3-tkinter
python3-customtkinter.noarch: W: no-documentation
python3-customtkinter.noarch: W: dangling-symlink /usr/lib/python3.15/site-packages/customtkinter/assets/fonts/Roboto/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf
python3-customtkinter.noarch: W: dangling-symlink /usr/lib/python3.15/site-packages/customtkinter/assets/fonts/Roboto/Roboto-Regular.ttf /usr/share/fonts/google-roboto/Roboto-Regular.ttf
2 packages and 0 specfiles checked; 0 errors, 4 warnings, 9 filtered, 0 badness; has taken 0.8 s
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.10.0
configuration:
/usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 1
python3-customtkinter.noarch: W: python-leftover-require python3-tkinter
python3-customtkinter.noarch: W: no-documentation
python3-customtkinter.noarch: W: dangling-symlink /usr/lib/python3.15/site-packages/customtkinter/assets/fonts/Roboto/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf
python3-customtkinter.noarch: W: dangling-symlink /usr/lib/python3.15/site-packages/customtkinter/assets/fonts/Roboto/Roboto-Regular.ttf /usr/share/fonts/google-roboto/Roboto-Regular.ttf
1 packages and 0 specfiles checked; 0 errors, 4 warnings, 5 filtered, 0 badness; has taken 0.5 s
Source checksums
----------------
https://files.pythonhosted.org/packages/source/c/customtkinter/customtkinter-5.2.2.tar.gz :
CHECKSUM(SHA256) this package : fd8db3bafa961c982ee6030dba80b4c2e25858630756b513986db19113d8d207
CHECKSUM(SHA256) upstream package : fd8db3bafa961c982ee6030dba80b4c2e25858630756b513986db19113d8d207
Requires
--------
python3-customtkinter (rpmlib, GLIBC filtered):
google-roboto-fonts
python(abi)
python3-tkinter
python3.15dist(darkdetect)
python3.15dist(packaging)
Provides
--------
python3-customtkinter:
python-customtkinter
python3-customtkinter
python3.15-customtkinter
python3.15dist(customtkinter)
python3dist(customtkinter)
Generated by fedora-review 0.12.0 (a08f0fc) last change: 2026-09-18
Command line :/usr/sbin/fedora-review -n python-customtkinter -m fedora-rawhide-aarch64 -B -L /tmp/opencode/review-2573565/artifacts
Buildroot used: fedora-rawhide-aarch64
Active plugins: Shell-api, Generic, Python
Disabled plugins: R, Ocaml, C/C++, Perl, Haskell, PHP, SugarActivity, Java, fonts
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH, UNRETIREMENT
Built with local dependencies:
/tmp/opencode/review-2573565/artifacts/python3-darkdetect-0.8.0-1.fc46.noarch.rpm
/tmp/opencode/review-2573565/artifacts/python-darkdetect-0.8.0-1.fc46.src.rpm
Needs the two [!] items addressed before approval; everything else in this
package is in good shape
Thank you for the thorough review. This update addresses both points: 1. Version: updated to 6.0.0. Before bumping it I checked ParrotIA against 6.0.0: its GUI and test suite pass unchanged, and with the new RPMs installed on Rawhide the real GUI starts and draws correctly under Xvfb. ParrotIA 1.4.1 (bug 2573567) now accepts customtkinter >= 5.2.2, < 7, so nothing depends on 5.2.2 anymore. 2. CustomTkinter_shapes_font.otf: I kept it private and recorded the rationale in the spec, after the Roboto symlinks in %install. The font has no text glyphs, only the circle, checkmark and arrow shapes the widgets are drawn with, and only CustomTkinter refers to it by family name. Installing it into %{_fontdir} would put a font that cannot render text into every application's font menu, and the loader would still need a patch to stop copying it into ~/.fonts. If you would still prefer a separate -fonts subpackage, I'm happy to do that. I also added Recommends: python3dist(pillow) for CTkImage, and a comment above %check explaining why upstream's manual GUI scripts can't be automated. Spec URL: https://raw.githubusercontent.com/igorbispo99/ParrotIA/v1.4.1/packaging/fedora/python-customtkinter.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/igorbispopessoal/parrotia/srpm-builds/11335704/python-customtkinter-6.0.0-1.fc46.src.rpm Copr build (Fedora 44, 45 and Rawhide): https://copr.fedorainfracloud.org/coprs/build/11335704/ Thanks these looks good to me. |