Bug 259901

Summary: Modifications required to port stunnel-4.20
Product: [Fedora] Fedora Reporter: Rob Crittenden <rcritten>
Component: nss_compat_osslAssignee: Rob Crittenden <rcritten>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: medium    
Version: 9CC: mitr, rrelyea, triage
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard: bzcl34nup
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-07-14 17:15:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
enhancements for stunnel-4.20 none

Description Rob Crittenden 2007-08-28 12:44:38 UTC
Enhancements submitted by Miloslav Trmac while porting to stunnel 4.20:

* Add DES and MD4 routines
* Define PEM_BUFSIZE
* Use a better X509_STORE_CTX (with ->current_cert, ->error)
* Add a dummy PEM_def_callback
* Add SSLv2_server_method
* Add X509_LU_X509, X509_STORE_get_by_subject
* Add SSL_get_ex_data_X509_STORE_CTX_idx, and a stub for
  X509_STORE_CTX_get_ex_data
* Uncomment declaration of SSL_state_string_long.  Return at least
  some string instead of NULL.
* Fix prototype of CRYPTO_set_locking_callback
* Use PK11_GenerateRandom, not PR_GetRandomNoise for RAND_write_file:
  RAND_write_file is used to keep a persistent random seed across
  stunnel runs, it is not really necessary to generate a truly random
  seed each time.  Besides, reading 1024 bytes from /dev/random takes
  way too long.
* Don't call fclose(NULL) in RAND_write_file
* Return NULL from SSL_get_peer_certificate if no peer certificate is
  available
* Decide whether to allocate memory in X509_NAME_oneline based on
  the passed buffer, not its size

Comment 1 Rob Crittenden 2007-08-28 12:44:38 UTC
Created attachment 176141 [details]
enhancements for stunnel-4.20

Comment 2 Rob Crittenden 2007-08-29 13:13:14 UTC
From Bob Relyea:

The MD4 code will not work. (It will crash in PK11_DigestBegin when you pass a
NULL pointer. NSS does not support MD4). We should check how MD4 is being used.
If it's NLTM, then we should plan on moving it to a generic NLTM library. (we
may want to put the NLTM library in the nss_compat_oss library maybe...

The DES code will work, except in FIPS mode. I'm not sure we want to encourage
use of this kind of API. The problem is the API is taking an explicit key (which
means the application has direct access to key material). This is a big no-no
from both a hygiene an a FIPS perspective.

The correct thing to do is look at where the key is coming from and force that
into the full NSS model. 

Comment 3 Bob Relyea 2007-08-29 20:32:10 UTC
We now know that the DES code is used for NTLM. This means bug 263241 is relevant.

Comment 4 Rob Crittenden 2007-09-20 15:48:11 UTC
Committed the patch excluding the DES and MD4 code.

Sending        src/nss_compat_ossl.h
Sending        src/rand.c
Sending        src/ssl.c
Transmitting file data ...
Committed revision 50.


Comment 5 Rob Crittenden 2007-09-20 18:04:11 UTC
The set of changes committed in #4 will appear in nss_compat_ossl-0.9.2-1

Bob, is there a better way (read FIPS-compatible) to add DES support?

Comment 6 Bug Zapper 2008-04-04 13:41:28 UTC
Based on the date this bug was created, it appears to have been reported
during the development of Fedora 8. In order to refocus our efforts as
a project we are changing the version of this bug to '8'.

If this bug still exists in rawhide, please change the version back to
rawhide.
(If you're unable to change the bug's version, add a comment to the bug
and someone will change it for you.)

Thanks for your help and we apologize for the interruption.

The process we're following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

Comment 7 Bug Zapper 2008-05-14 03:09:28 UTC
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 8 Bug Zapper 2009-06-09 22:47:41 UTC
This message is a reminder that Fedora 9 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 9.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '9'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 9's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 9 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 9 Bug Zapper 2009-07-14 17:15:15 UTC
Fedora 9 changed to end-of-life (EOL) status on 2009-07-10. Fedora 9 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.