Bug 262361
| Summary: | emacs-vm update causes emacs startup error | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marc Schwartz <marc_schwartz> | ||||||
| Component: | emacs-vm | Assignee: | Jonathan Underwood <jonathan.underwood> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | urgent | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 7 | CC: | wahjava, whanlon | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | i386 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 8.0.3.495-3.fc7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-09-04 22:11:03 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Marc Schwartz
2007-08-29 03:42:18 UTC
Thanks for the report - this is a known issue upstream: http://groups.google.co.uk/group/gnu.emacs.vm.bug/browse_thread/thread/341cd49565847957/7655101246e21b03#7655101246e21b03 alas, not yet resolved. For now, until I or someone works out the issue, I suggest reverting to the previous package. Thanks for the update Jonathon. Just as an FYI, the prior versions of the RPMS are available here: http://koji.fedoraproject.org/koji/buildinfo?buildID=12979 I went back to emacs-vm.i386 8.0.2.482-4.fc7 and emacs-vm-el.i386 8.0.2.482-4.fc7 I have installed them and am back to running. Installing these RPMS will overwrite vm-mode-init.el, removing the commenting of line 4. Jonathon, I think that I may have identified the problem and a fix. I downloaded both sets of RPMS and used: rpm2cpio EACH.RPM.FILE | cpio -idv to extract the files from all four RPMS into version specific directory trees. I then ran a recursive 'diff' on both versions to try to identify file based differences between the two versions. I will attach that diff here for you. In reviewing the diff output, I noted that one of the changes in vm-autoloads.el was the replacement of: (custom-add-load 'vm 'vm-vars) with: (custom-add-load 'vm-cus-load) towards the end of the file on line 3445. Given the comments in the thread you noted regarding 'custom-add-load' requiring two arguments and the two arguments used in the prior version of the file, I re-installed the version 495 rpms and edited vm-autoloads.el so that the above line now reads: (custom-add-load 'vm 'vm-cus-load) and then byte-compiled the file to update and replace the .elc file. Emacs now loads without issuing any error messages. It is not clear to me that this is the correct fix, but it is consistent with the prior version and does seem to work. I hope that this helps. Created attachment 181181 [details] Recursive diff of versions 482 and 495 This is a recursive diff of the files extracted from: emacs-vm-8.0.2.482-4.fc7.i386.rpm emacs-vm-el-8.0.2.482-4.fc7.i386.rpm versus: emacs-vm-8.0.3.495-2.fc7.i386.rpm emacs-vm-el-8.0.3.495-2.fc7.i386.rpm The potentially relevant output for: diff -r 482/usr/share/emacs/site-lisp/vm/vm-autoloads.el 495/usr/share/emacs/site-lisp/vm/vm-autoloads.el begins on line 176: 3439c3445 < (custom-add-load 'vm 'vm-vars) --- > (custom-add-load 'vm-cus-load) OK, thanks for taking the time to analyse this. I'll push builds with this fix later tonight. Thanks Jonathon. I posted a link to this bug report in the usenet thread above. Created attachment 182061 [details]
Patch to fix error in Makefile.in
Actually vm-autoloads.el is a file generated at build time, and so the way to
fix this when starting from the tarball is to patch Makefile.in. The attached
patch does that.
Have built new packages with the fix applied - you can pull them from Koji here: http://koji.fedoraproject.org/koji/taskinfo?taskID=142282 I will push them to updates testing too (will take a couple of days to appear on the mirrors). Jonathon, The new RPMS are working. Thanks for the rapid turnaround on this. *** Bug 274581 has been marked as a duplicate of this bug. *** emacs-vm-8.0.3.495-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |