Bug 271141
| Summary: | Vnc doesn't build against current versions of xorg-x11-server | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Kundrak <lkundrak> | ||||
| Component: | vnc | Assignee: | Adam Tkac <atkac> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 7 | CC: | ajax, ovasik | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 4.1.2-18.1 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-09-24 15:10:12 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Better should be merge that patch to main Xorg branch or drop it. Ajax, what do you think about this patch? Created attachment 185131 [details]
Discussed patch
I'm not sure I like that patch. We don't build the Xorg server for s390{,x} at
all right now, so there's really no point trying to build the vnc module for s390.
I'd just not build libvnc.so on s390 for now, but we probably want to fix s390
Xorg builds for real sometime. (When we do, we won't bother with arch defines
in int10 at all, for example, because s390 doesn't have a PCI bus so there's no
possible way you'd want to build int10 support.)
After inspection vnc will be built with --disable-xorg option so no patch is needed. Commited into CVS but release will wait for more serious issue. |
Description of problem: These lines from FC-7 vnc.spec bother me: 56 BuildRequires: xorg-x11-server-source ... 91 cp -r %{_datadir}/xorg-x11-server-source unix ... 102 pushd unix/xorg-x11-server-source* 103 %patch14 -p3 -b .s390 104 popd The dependency on xorg-x11-server-source is unversioned and the s390 patch does not apply against latest xorg-x11-server from both FC-7 and Rawhide.