Bug 274891
Summary: | Review Request: libedit - The NetBSD Editline library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Debarshi Ray <debarshir> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | chris.stone, fedora-package-review, jeff, notting |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-09-04 17:08:50 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Debarshi Ray
2007-09-03 06:26:27 UTC
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. e8abd1169825efecfccb0f7b4c338bb5 libedit-20070831-2.10.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + libedit.pc files are present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + libedit package -> Provides: libedit.so.0 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.2) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libedit.so.0 libncurses.so.5 rtld(GNU_HASH) +libedit-devel package -> Requires: libedit = 2.10-1.20070831cvs.fc8 libedit.so.0 ncurses-devel pkgconfig + Not a GUI app. APPROVED. New Package CVS Request ======================= Package Name: libedit Short Description: The NetBSD Editline library. Owners: rishi Branches: FC-6, F-7 InitialCC: Cvsextras Commits: no I assume you are just taking over the orphaned libedit package? I've marked you as owner of that package. Package Change Request ====================== Package Name: libedit New Branches: F-8 cvs done. Package Change Request ====================== Package Name: libedit New Branches: EL-5 cvs done. |