Bug 277921
Summary: | Review Request: jgoodies-forms - Java layout framework | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mary Ellen Foster <mefoster> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-10-30 10:46:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mary Ellen Foster
2007-09-05 07:44:52 UTC
! Well, actually I don't know how to use this package and I don't know well about Java, however anyway I will try to review this. * CLASSPATH - I don't know what CLASSPATH does, however many other review requests seem to set CLASSPATH as "" (e.g. bug 251428). Would you try that? * Timestamp - When using "install" or "cp" command, add "-p" option to keep timestamps. * Misc rpmlint issues ---------------------------------------------------------------- jgoodies-forms.src: W: mixed-use-of-spaces-and-tabs (spaces: line 65, tab: line 59) jgoodies-forms.src: W: strange-permission jgoodies-forms-build.patch 0600 jgoodies-forms.src: W: strange-permission forms-1_1_0.zip 0600 jgoodies-forms.noarch: W: file-not-utf8 /usr/share/doc/jgoodies-forms-1.1.0/docs/tutorial/introduction.html jgoodies-forms.noarch: W: file-not-utf8 /usr/share/doc/jgoodies-forms-1.1.0/docs/reference/colsandrows.html jgoodies-forms.noarch: W: file-not-utf8 /usr/share/doc/jgoodies-forms-1.1.0/docs/reference/cells.html ---------------------------------------------------------------- SUMMARY: - Unify indentation. Please use spaces or tabs, not both - Change the permission of the files in srpm to 0644. - Change the encodings of HTML files to UTF-8. ! Note: When changing the encodings of HTML files into UTF-8, you also have to change the string of "charset". For example, /usr/share/doc/jgoodies-forms-1.1.0/docs/tutorial/introduction.html contains the line: ---------------------------------------------------------------- <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> ---------------------------------------------------------------- I've addressed all of your issues: http://mef.fedorapeople.org/packages/jgoodies/jgoodies-forms.spec http://mef.fedorapeople.org/packages/jgoodies/jgoodies-forms-1.1.0-2.fc7.src.rpm Diff of spec file between 1 and 2 shows: ---------------------------------------------------------- %clean -rm -rf $RPM_BUILD_ROOT +# rm -rf $RPM_BUILD_ROOT ---------------------------------------------------------- Please don't remove this line. Other things are okay. ---------------------------------------------------------- This package (jgoogies-forms) is APPROVED by me ---------------------------------------------------------- New Package CVS Request ======================= Package Name: jgoodies-forms Short Description: Java layout framework Owners: mef Branches: F-7 InitialCC: Cvsextras Commits: yes Mass branching for F-8 has happened, so I assume you wanted a F-8 branch as well. cvs done. Please rebuild this package and import this to Fedora. Sorry about that, I was waiting to see if there was any progress on the jgoodies-looks package. |