Bug 281601
| Summary: | Review Request: xsc - A clone of the old vector graphics video game Star Castle | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.5-2.fc7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-09-12 16:43:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gwyn Ciesla
2007-09-06 22:33:21 UTC
I'll review this, Jon could you review umbrello in return please? The umbrello review is bug 283471. Fully reviewed. Must Fix: --------- * Add "Requires: hicolor-icon-theme" for dir ownership Should Fix: ----------- * run "convert xsc.png -transparent white out.png" and then replace xsc.png with out.png to make the icon transparent (much nicer). Addressed. I'll get on ubrello very, very, soon. :) Spec URL: http://zanoni.jcomserv.net/fedora/xsc/xsc.spec SRPM URL: http://zanoni.jcomserv.net/fedora/xsc/xsc-1.5-2.fc7.src.rpm Approved! Many thanks! New Package CVS Request ======================= Package Name: xsc Short Description: A clone of the old vector graphics video game Star Castle Owners: limb Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes Whoops: New Package CVS Request ======================= Package Name: xsc Short Description: A clone of the old vector graphics video game Star Castle Owners: limb Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes cvs done. Build failed in devel. http://koji.fedoraproject.org/koji/getfile?taskID=153467&name=build.log Tried it in local mock, which failed, the same way. I tried adding libX11-devel to the BRs, and still nothing. Suggestions? You probably need to add "libXt-devel" to the BuildRequires (don't ask). Wow, that worked in local mock. I can't figure out why, as all the lib strings in the executable are from libX11 and xorg-X11-proto-devel. I've submitted to koji for devel, but it appears to be slightly backlogged. Thanks. Ok, the koji build failed. http://koji.fedoraproject.org/koji/getfile?taskID=154305&name=build.log http://koji.fedoraproject.org/koji/getfile?taskID=154305&name=root.log (In reply to comment #10) > Wow, that worked in local mock. I can't figure out why, as all the lib strings > in the executable are from libX11 and xorg-X11-proto-devel. I've submitted to > koji for devel, but it appears to be slightly backlogged. > libXt-devel is needed because old configure scripts check for X11/Intrinsic.h, even though apps usually don't use that :) (In reply to comment #11) > Ok, the koji build failed. > http://koji.fedoraproject.org/koji/getfile?taskID=154305&name=build.log > http://koji.fedoraproject.org/koji/getfile?taskID=154305&name=root.log > Hmm, looks like 64bit issue, investigating. Okay, passing: '--x-includes="" --x-libraries=""' to %configure should disable configures broken X checking without any side-effects and thus be the easiest way to fix this. You can then also drop the libXt-devel BR. Worked like a charm. Added your line, and had to add libX11-devel back, and it worked, in a local mock build and koji devel. Many thanks. I can't actually test anything x64 wise. I have a machine in the house with the appropriate hardware support, but my wife has it running That Other OS. For now. :) xsc-1.5-2.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |