Bug 284101
| Summary: | Review Request: python-textile - A Humane Web Text Generator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Moschny <thomas.moschny> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davidf, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.0.11-4.fc7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-04-23 09:12:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Thomas Moschny
2007-09-09 19:09:52 UTC
Spec URL: http://thm.1erlei.de/python-textile.spec SRPM URL: http://thm.1erlei.de/python-textile-2.0.11-2.fc8.src.rpm - Updated main and source urls. - The website states that the package is now under the MIT License. - Fix mixed spaces/tabs issue reported by rpmlint. Sponsorship was offered in bug 284961. Builds clean and rpmlint finds nothing to complain about. When in doubt, trust the license on the code and not what's listed on a web site. While I don't think the difference between BSD (without advertising) and MIT is particularly significant, we should at least get it right even when upstream doesn't seem to know the difference. So I think that "BSD" is indeed the correct License: tag here. The tarball in this package and the one currently at the upstream web site are not the same. Any idea what's up there? The size is different but the content seems to be the same. (In reply to comment #3) > When in doubt, trust the license on the code and not what's listed on a web > site. While I don't think the difference between BSD (without advertising) > and MIT is particularly significant, we should at least get it right even > when upstream doesn't seem to know the difference. So I think that "BSD" is > indeed the correct License: tag here. Ok, reverted the tag. Also asked upstream to clarify. > The tarball in this package and the one currently at the upstream web site > are not the same. Any idea what's up there? The size is different but the > content seems to be the same. Upstream seems to have repackaged it when when moving to googlecode. The older archive was downloaded from http://pypi.python.org/pypi/textile/ . Anyway, I rebuilt the srpm. Spec URL: http://thm.1erlei.de/python-textile.spec SRPM URL: http://thm.1erlei.de/python-textile-2.0.11-3.fc8.src.rpm Anything missing for the review? I'm guessing that upstream never clarified, but in any case I don't think it matters much as we have the license * source files match upstream: 8d1f277c541d2638f8be3fa5ebb01762e01ce9d1792ae7bcdca443716964bf59 textile-2.0.11.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: python-textile = 2.0.11-3.fc9 = python(abi) = 2.5 python-twisted-core * %check is not present; no test suite upstream. I have no ability to test this software. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * egg-info files are built and included in the package. APPROVED Thanks for reviewing! New Package CVS Request ======================= Package Name: python-textile Short Description: A Humane Web Text Generator Owners: thm Branches: F-7 F-8 InitialCC: none Cvsextras Commits: yes cvs done. python-textile-2.0.11-4.fc8 has been submitted as an update for Fedora 8 python-textile-2.0.11-4.fc7 has been submitted as an update for Fedora 7 python-textile-2.0.11-4.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-textile'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F7/FEDORA-2008-2978 python-textile-2.0.11-4.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. python-textile-2.0.11-4.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |