Bug 289241
| Summary: | Review Request: qimageblitz - Interim image effect library for KDE 4.0 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Kofler <kevin> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, notting, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-09-19 21:24:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 289251 | ||
|
Description
Kevin Kofler
2007-09-13 13:15:33 UTC
Looks good, simple and clean. 1 comment: * move blitztest out of main pkg, it appears to be only an example/test app, not something required for runtime use. Address this, and I'll approve. I've wondered about what to do with that one. Where should I move it to: * qimageblitz-devel? * a new qimageblitz-examples (which would contain only one file)? * just rm it? Any of those is ok with me... maybe prefer simply removing it for now (perhaps checking to see what other distros do with it). Mandriva has 3 packages: * qimageblitz: contains only blitztest * %mklibname qimageblitz 4 (they love macros over at Mandriva): contains *.so.* * %mklibname -d qimageblitz: contains the devel files OpenSUSE has 2 packages (libqimageblitz and libqimageblitz-devel), they put blitztest into libqimageblitz-devel. Debian and Ubuntu also have 2 packages (libqimageblitz4 and libqimageblitz-dev), they also put blitztest into libqimageblitz-dev. kde-windows has qimageblitz-mingw-20070915-bin.zip (the equivalent of our qimageblitz), qimageblitz-mingw-20070915-lib.zip (the equivalent of our qimageblitz-devel) and qimageblitz-mingw-20070915-src.zip (the equivalent of our SRPM), they put blitztest.exe into -bin (i.e. the runtime package). So we have: * the 3-package approach (Mandriva) * the 2-package approach with blitztest in -devel (openSUSE, Debian, Ubuntu) * the 2-package approach with blitztest in the main package (kde-windows) all used in the wild already. I'm personally leaning for qimageblitz-examples as the most logical solution, it's also consistent with how other libraries are packaged, and it also scales if they ever decide to add more examples. worksforme, APPROVED. Done: Spec URL: http://repo.calcforge.org/f8/qimageblitz.spec SRPM URL: http://repo.calcforge.org/f8/qimageblitz-0.0.4-0.2.svn706674.fc7.src.rpm New Package CVS Request ======================= Package Name: qimageblitz Short Description: Interim image effect library for KDE 4.0 Owners: kkofler,than,rdieter Branches: F-7 InitialCC: Cvsextras Commits: no cvs done. Built for Rawhide and F7, push to F7 updates-testing requested. |