Bug 295041
Summary: | Review Request: python-fedora - Python modules for talking to Fedora Infrastructure Services | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Toshio Ernie Kuratomi <a.badger> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, lmacken, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://hosted.fedoraproject.org/projects/python-fedora | ||
Whiteboard: | |||
Fixed In Version: | 0.2.90.19-1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-09-25 21:44:30 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Toshio Ernie Kuratomi
2007-09-18 16:30:48 UTC
Updated version: Add bugzilla email for control-center-maint Spec URL: http://toshio.fedorapeople.org/packages/python-fedora.spec SRPM URL: http://toshio.fedorapeople.org/packages/python-fedora-0.2.90.18-1.fc7.src.rpm Updated version: Fix build on rawhide Spec URL: http://toshio.fedorapeople.org/packages/python-fedora.spec SRPM URL: http://toshio.fedorapeople.org/packages/python-fedora-0.2.90.18-2.fc7.src.rpm Looks pretty good to me. rpmbuild says: python-fedora-infrastructure.noarch: W: no-documentation which is no big deal. There's a typo in the Source0 line (should be toshio.fedorapeople.org). I'm curious about the zero-length __init__.py files; I figured rpmlint would complain about them but they're explicitly exempted from the check so I suppose they're required. * source files match upstream: aeeee4d9a2dace30ff60fa0ec86540c26b65e825e84b99124f2de42eee13f91d python-fedora-0.2.90.18.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has acceptable complaints. * final provides and requires are sane: python-fedora-0.2.90.18-2.fc8.noarch.rpm python-fedora = 0.2.90.18-2.fc8 = python(abi) = 2.5 python-simplejson python-fedora-infrastructure-0.2.90.18-2.fc8.noarch.rpm python-fedora-infrastructure = 0.2.90.18-2.fc8 = python(abi) = 2.5 python-fedora = 0.2.90.18-2.fc8 python-psycopg2 python-sqlalchemy * %check is not present; no test suite upstream. You wrote this so I assume you know if it works or not. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED; the only needed change I see is the Source0 line. The __init__.py files are required for Python to see those directories as containing modules. Thanks tibbs! Updated source package with fixed Source0 line. This is what will be imported to the repository: Spec URL: http://toshio.fedorapeople.org/packages/python-fedora.spec SRPM URL: http://toshio.fedorapeople.org/packages/python-fedora-0.2.90.18-3.fc7.src.rpm New Package CVS Request ======================= Package Name: python-fedora Short Description: Python modules for talking to Fedora Infrastructure Services Owners: toshio,lmacken,ricky,mmcgrath Branches: FC-6 F-7 EL-5 devel InitialCC: Cvsextras Commits: yes CVS done. Packages imported and built for FC-6, F-7, EL-5, and devel. |