Bug 295761

Summary:	Review Request: solarwolf - A Python port of SolarFox
Product:	[Fedora] Fedora	Reporter:	Gwyn Ciesla <gwync>
Component:	Package Review	Assignee:	Hans de Goede <hdegoede>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, hdegoede, notting
Target Milestone:	---	Flags:	hdegoede: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	1.5-2.fc7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-09-25 08:28:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Gwyn Ciesla 2007-09-19 02:57:33 UTC

Spec URL: http://zanoni.jcomserv.net/fedora/solarwolf/solarwolf.spec
SRPM URL: http://zanoni.jcomserv.net/fedora/solarwolf/solarwolf-1.5-1.fc7.src.rpm
Description: The point of the game is to scramble through 60 levels
collecting space boxes. Each level gets is harder than
the previous. Obstacles like bullets, mines, and asteroids
cover your every move. Beat the Skip timer and grab the
powerups for your only chance.

Comment 1 Hans de Goede 2007-09-19 12:22:13 UTC

Shall we swap reviews again? It would be nice if you could review sdljava, then
I'm one step closer to getting bolzplatz approved (funny 3d footbal game, only
works on Fedora 8 test).

Comment 2 Hans de Goede 2007-09-19 12:39:35 UTC

Fully reviewed.

Must Fix:
---------
* Source0 gives a 404 error
* Use install -p -m 755 for .py file to preserve timestamp

Should fix:
-----------
* Use install -p -m 644 for the data files, moving them away will break 
  --shortcircuit builds
* Once this is done the chmod's are no longer needed, instead put a
  "#nothing to build" line in %build

Comment 3 Gwyn Ciesla 2007-09-19 23:01:52 UTC

I fixed the Source0.

If I change to install, it complains that it omits the data/audio and data/music
directories, and kills the build.  How do I get around that?  That's why I used
mv to begin with.  

Also, the chmods are to correct incorrect permissions in the source, not to
specify them during the install of the package.  Without the chmod, the %clean
and %install sections do not have rights to rm -rf %{buildroot}.

Comment 4 Hans de Goede 2007-09-20 06:19:07 UTC

(In reply to comment #3)
> If I change to install, it complains that it omits the data/audio and data/music
> directories, and kills the build.  How do I get around that?  That's why I used
> mv to begin with.  
> 

Ah, my bad, I missed that there were subdirs, use "cp -a" then (cp to not erase
the source files, -a to preserve timestamps)

> Also, the chmods are to correct incorrect permissions in the source, not to
> specify them during the install of the package.  Without the chmod, the %clean
> and %install sections do not have rights to rm -rf %{buildroot}.

Ah, I see, put them in %prep then please

Comment 5 Gwyn Ciesla 2007-09-21 11:41:41 UTC

Addressed.

Spec URL: http://zanoni.jcomserv.net/fedora/solarwolf/solarwolf.spec
SRPM URL: http://zanoni.jcomserv.net/fedora/solarwolf/solarwolf-1.5-2.fc7.src.rpm

Comment 6 Hans de Goede 2007-09-21 12:45:31 UTC

Approved!

Comment 7 Gwyn Ciesla 2007-09-21 12:54:43 UTC

Thank you!

New Package CVS Request
=======================
Package Name: solarwolf
Short Description: A Python port of SolarFox
Owners: limb
Branches: FC-6 F-7
InitialCC: 
Cvsextras Commits: yes

Comment 8 Hans de Goede 2007-09-21 13:19:28 UTC

You accidentally set the relase notes flag instead of the cvs one, fixing.

Comment 9 Gwyn Ciesla 2007-09-21 13:41:11 UTC

Thanks.

modprobe caffiene

Comment 10 Kevin Fenzi 2007-09-21 16:16:27 UTC

cvs done.

Comment 11 Fedora Update System 2007-09-25 08:28:38 UTC

solarwolf-1.5-2.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.