Bug 2965

Summary: ikon2xbm need lesser page-width
Product: [Retired] Red Hat Linux Reporter: chj
Component: facesAssignee: Preston Brown <pbrown>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 1999-09-05 20:14:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description chj 1999-05-22 13:30:48 UTC
The following is an example face two-line file:

2tQjSw>|IA680lA7r'G9Y[jfoS>tTPw4-B#mQo_C+{6>^DWZP`o.h<N!-!iBER@5!"`:9^t

~MyeXP43[]t)W-sTm)TibB_c4=**35T?X(,6,POUlqae[Aq$"zn4hN{{w@(=rYp\i=\wUyhL

Running it as this

uncompface example.face | ikon2xbm > example.xmb

gives an error:

icontopbm: error 4 scanning bits item
pbmtoxbm: EOF / read error reading magic number

The error is ``cured'' by adding a page-width directive of
-w55 to the pr command in ikon2xbm:

*** ikon2xbm.orig       Fri May  1 03:19:12 1998
--- ikon2xbm    Tue Jun 16 19:30:42 1998
***************
*** 28,34 ****

  dim=`wc -l < $tmp | awk '{ print 4 * sqrt($1) }'`

! pr -l1 -t -8 -s, < $tmp |
  (cat << EOF
  /* Format_version=1, Width=$dim, Height=$dim, Depth=1,
Valid_bits_per_item=16
   */
--- 28,34 ----

  dim=`wc -l < $tmp | awk '{ print 4 * sqrt($1) }'`

! pr -w55 -l1 -t -8 -s, < $tmp |
  (cat << EOF
  /* Format_version=1, Width=$dim, Height=$dim, Depth=1,
Valid_bits_per_item=16
   */

Comment 1 Michael K. Johnson 1999-07-29 21:31:59 UTC
That 55 looks random.  How do you know that is always gives the
right number of rows/columns and never hurts the output?

Comment 2 Michael K. Johnson 1999-07-30 13:56:59 UTC
It looks like the -w55 simply removes exess space, so we should
apply the patch.  Thanks!

Comment 3 Jeff Johnson 1999-09-05 20:14:59 UTC
Fixed in faces-1.6.1-17. Thanks for the patch.