Bug 297271

Summary: poor contrast of current selection in unfocused GtkTreeView
Product: [Fedora] Fedora Reporter: Jens Petersen <petersen>
Component: gtk-nodoka-engineAssignee: Martin Sourada <martin.sourada>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: rawhideKeywords: Reopened
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-09-25 04:23:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 235704    
Attachments:
Description Flags
clearlooks.png
none
nodoka.png
none
nodoka-insensitive.png
none
imchooser-disabled.png
none
imchooser.png
none
last imchooser screeshot none

Description Jens Petersen 2007-09-20 01:32:39 UTC 
Description of problem:
The Nodoka theme seems to contrast the current selection badly in
unfocused GtkTreeView widgets.  When a GtkTreeView widget is made
insensitive the highlighting is also a bit strange.

Version-Release number of selected component (if applicable):
nodoka-theme-gnome-0.3.2-1.fc8.1

How reproducible:
every time

Steps to Reproduce:
1. install scim and run im-chooser, or install gtk2-devel and run gtk-demo
2. press Tab or click to move focus around window
3. in im-chooser disable input methods

Actual results:
2. Quite unclear unhighlighting of current selection in TreeView when unfocused.
3. Text of current selection does not fade.

Expected results:
2. Clear distinction between current selection in TreeView and other entries.
3. last selection text should also appear lighter

Additional info:
I wonder if this should be a F8Blocker.
Comment 1 Jens Petersen 2007-09-20 02:38:51 UTC 
Created attachment 200371 [details]
clearlooks.png

screenshot of im-chooser with ClearLooks theme
Comment 2 Jens Petersen 2007-09-20 02:40:20 UTC 
Created attachment 200381 [details]
nodoka.png

shot of im-chooser with Nodoka.
Comment 3 Jens Petersen 2007-09-20 03:30:44 UTC 
I can attach screenshots for the insensitive case too if you want.
Comment 4 Martin Sourada 2007-09-20 04:32:03 UTC 
Thanks for the screenshots, when I read the description I thought at first, that
the text contrast badly with the background... :)

It seems Clearlooks does not make differences between selection in focused
window and in unfocused window (i.e. both are blue), in Nodoka we do it by
making the selection grey if in unfocused widget. What solution to this bug
would you prefer?

a) usage of darker grey
b) leave it blue for unfocused widgets as well

Thanks
Comment 5 Jens Petersen 2007-09-20 04:59:15 UTC 
Darker grey sounds good to me, thanks.
Comment 6 Jens Petersen 2007-09-20 06:25:02 UTC 
Created attachment 200501 [details]
nodoka-insensitive.png

Here is a screenshot of the insensitive widget too.
Comment 7 Martin Sourada 2007-09-20 21:08:55 UTC 
Hi, I fixed the treeview issue in gtk-nodoka-engine-0.6-2.fc8. Please check, if
it's what you wanted (if not, reopen the bug). About the insensitive case I am
not quite sure - it does not seem wierd to me. If you insist on it, please open
a separate bug about it (one bug for one issue seems good to me).

Thanks :)
Comment 8 Jens Petersen 2007-09-24 04:37:59 UTC 
IMHO it is still not dark enough, could you please make it darker grey.
Comment 9 Jens Petersen 2007-09-24 04:41:16 UTC 
Created attachment 203681 [details]
imchooser-disabled.png

how it looks now
Comment 10 Jens Petersen 2007-09-24 04:44:43 UTC 
Created attachment 203691 [details]
imchooser.png

err, rather this one
Comment 11 Martin Sourada 2007-09-24 11:33:35 UTC 
Created attachment 204041 [details]
last imchooser screeshot

This is how it looks in latest package. If you are OK with this one, I'll close
this bug again. Thanks.
Comment 12 Jens Petersen 2007-09-25 04:16:51 UTC 
Thanks!  That's much better.