Bug 300001

Summary:	Superfluous newline when replying to mail.
Product:	[Fedora] Fedora	Reporter:	David Woodhouse <dwmw2>
Component:	evolution	Assignee:	Matthew Barnes <mbarnes>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-09-21 20:13:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Woodhouse 2007-09-21 11:34:44 UTC

After updating to rawhide, Evolution seems to have started inserting an unwanted
newline at the start of all replies. Where before the citation line 'On Fri,
2007-09-21 at 11:32 +0100, David Woodhouse wrote:' would be the first line in
the mail, there's now an unwanted blank line before it which needs to be deleted.

Comment 1 Matthew Barnes 2007-09-21 17:11:10 UTC

Probably a side-effect of the new top-posting option.  I'll look into it.

Comment 2 Matthew Barnes 2007-09-21 20:13:56 UTC

Believe it or not, this was actually done on purpose.

See: http://bugzilla.gnome.org/show_bug.cgi?id=450820

  "I dont think it is a bad idea to add a new line before the mail in the
   reply though the reply may be inserted between the quotes, the first line
   often has a greeting. 

   But I really hate an option for this. I would prefer to push the patch and
   hear from the users. It is possible that it can be annoying, but we have
   the luxury to test this in head and revert if the users start complaining."

Have at it.  :)

The offending function is mail/em-format-quote.c:emfq_format_clone().

Comment 3 Matthew Barnes 2007-09-21 20:37:00 UTC

See also: http://bugzilla.gnome.org/show_bug.cgi?id=469292

Comment 4 David Woodhouse 2007-09-21 21:24:43 UTC

But we already _have_ a top-posting option. That's just silly.

Comment 5 Matthew Barnes 2007-09-21 23:39:03 UTC

I think the option is about where to put the signature, but yeah.

Apparently top-posting corporate Exchange users are demanding it.  I suggested
that we use the account type as a heuristic: Exchange and GroupWise users can
have their newline, the rest of us know better.

Comment 6 David Woodhouse 2007-09-21 23:46:45 UTC

Bah. I'm not going to get into a bunfight with Evolution upstream; life's too
short. Another patch to add to my collection, I suppose. I'm still having to
build my own version of Evolution to work around GNOME #336074 and make it at
all usable, and I also still carry an attempt at fixing the '^From ' mangling too.

Would be nice if I could just use the stock Fedora build of Evolution some day :)