Bug 302451
Summary: | Review Request: baekmuk-bdf-fonts - Korean bitmap fonts (separated from fonts-korean) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | eng-i18n-bugs, fedora-package-review, K9, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
petersen: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-09-24 12:44:18 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 300651 | ||
Bug Blocks: | 253155 |
Description
Jens Petersen
2007-09-24 01:29:36 UTC
(baekmuk-ttf-fonts review is bug 300651.) * Similar with bug 300651, COPYRIGHT.ks can be converted to UTF-8. * Well, while this package uses relative symlink on %_sysconfdir/X11/fontpath.d, bug 300651 uses absolute symlink. Would you unify them? (for these symlinks, all other packages seem to use absolute symlinks) * %ghost %verify(not md5 size mtime) files "fonts.cache-1" "encodings.dir" are no longer needed? * Also, Similar with bug 300651, "Conflicts: fonts-korean <= <somever>" is better IMO ... By the way koji seems down > * Similar with bug 300651, COPYRIGHT.ks can be converted to UTF-8. Yes, thanks. > * Well, while this package uses relative symlink on > %_sysconfdir/X11/fontpath.d, bug 300651 uses absolute symlink. > Would you unify them? (for these symlinks, all other packages > seem to use absolute symlinks) Actually now I made it relative in baekmuk-ttf-fonts now too, but if it is a bad idea I can revert. > * %ghost %verify(not md5 size mtime) files > "fonts.cache-1" "encodings.dir" are no longer needed? Yes, I think they can go. (In reply to comment #3) > Similar with bug 300651, "Conflicts: fonts-korean <= <somever>" is better Hmm, maybe it makes sense, though I think this is no actual conflict of files. > ... By the way koji seems down Seems to be mostly back now, I think. :) Spec URL: http://people.redhat.com/petersen/reviews/baekmuk-bdf/baekmuk-bdf-fonts.spec SRPM URL: http://people.redhat.com/petersen/reviews/baekmuk-bdf/baekmuk-bdf-fonts-2.2-2.fc7.src.rpm (In reply to comment #4) > > * Well, while this package uses relative symlink on > > %_sysconfdir/X11/fontpath.d, bug 300651 uses absolute symlink. > > Would you unify them? (for these symlinks, all other packages > > seem to use absolute symlinks) > > Actually now I made it relative in baekmuk-ttf-fonts now too, but if > it is a bad idea I can revert. - I don't know which is better (although I prefer relative). > > > * %ghost %verify(not md5 size mtime) files > > "fonts.cache-1" "encodings.dir" are no longer needed? > > Yes, I think they can go. Thanks. > > (In reply to comment #3) > > Similar with bug 300651, "Conflicts: fonts-korean <= <somever>" is better > > Hmm, maybe it makes sense, though I think this is no actual conflict > of files. - Yes, there is no actual conflict, however baekmuk-bdf and old fonts-korean rpms owns same files and marking conflicts is better (IMO) > - Yes, there is no actual conflict, however baekmuk-bdf and old > fonts-korean rpms owns same files and marking conflicts is better > (IMO) Ok, thanks, added. Spec URL: http://people.redhat.com/petersen/reviews/baekmuk-bdf/baekmuk-bdf-fonts.spec SRPM URL: http://people.redhat.com/petersen/reviews/baekmuk-bdf/baekmuk-bdf-fonts-2.2-3.fc7.src.rpm Okay. ---------------------------------------------------------- This package (baekmuk-bdf-fonts) is APPROVED by me ---------------------------------------------------------- Thanks for quick review. Thanks. New Package CVS Request ======================= Package Name: baekmuk-bdf-fonts Short Description: Korean bitmap fonts Owners: cchance Branches: devel InitialCC: petersen Cvsextras Commits: yes cvsadmin done Package has been imported and built. Thank you very much. |