Bug 303841
| Summary: | Review Request: libflashsupport - Optional Library Interfaces for Adobe Flash Player | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Warren Togami <wtogami> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
wtogami: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-09-25 17:14:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Warren Togami
2007-09-24 19:05:55 UTC
MUST Not sure about these two: • package name: -pulse removed? • library -> ldconfig: confirmation: not needed? I tried calling ldconfig manually and get the following: /sbin/ldconfig: /usr/lib/libflashsupport.so is not a symbolic link but pulseaudio-lib's libflashsupport does this too. Replacing the libflashsupport.so file with the one from the RPM works, so this is probably OK OK: • rpmlint: src clean, binary missing doc (upstream), contains .so (ok -- does not contain .so.*) • spec file name: matches package name • package guideline-compliant: OK • license complies with guidelines: • license field accurate: OK • spec in US English: OK • spec legible: OK • source matches upstream: OK (SVN) • builds under >= 1 archs, others excluded: OK • build dependencies complete • own all directories: OK • no dupes in %files: OK • permission: OK • %clean RPM_BUILD_ROOT: OK • Package contains code: OK • clean buildroot before install: OK • filenames UTF-8: OK SHOULD • if license text missing, ask upstream to include it • package build in mock on all architectures: OK • package functioned as described: OK • require package not files: OK Warren, could you make libflashsupport.i386 available on the x86_64 tree as well? Thanks. |