Bug 304191
Summary: | dbscan doesn't handle RUV entries in changelog db | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Retired] 389 | Reporter: | Nathan Kinder <nkinder> | ||||||
Component: | Command Line Utilities | Assignee: | Nathan Kinder <nkinder> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Viktor Ashirov <vashirov> | ||||||
Severity: | low | Docs Contact: | |||||||
Priority: | low | ||||||||
Version: | 1.1.0 | ||||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2015-12-07 16:59:37 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 240316, 427409 | ||||||||
Attachments: |
|
Description
Nathan Kinder
2007-09-24 22:04:38 UTC
Created attachment 204611 [details]
CVS Diffs
Looks good. You should probably put a comment near the definition of ENTRY_COUNT_KEY etc. explaining where these values come from in cl5_api.c. Also, it looks as though there is a bug in cl5ReadBervals(). In your code, you use ntohl to read the number of bervals. But in the cl5 code, it uses PR_htonl to read this value. This is not correct because it uses PR_htonl to encode the values. This is also in cl5_api.c. :) If you have a chance to fix the bug that Rich pointed out above, could you add (time_t) before passing type to csn_set_time? static char* _cl5GetHelperEntryKey (int type, char *csnStr) { CSN *csn= csn_new(); char *rt; csn_set_time(csn, type); <=== type: cast to time_t. void csn_set_time(CSN *csn, time_t csntime) { csn->tstamp= csntime; } struct csn { time_t tstamp; Created attachment 204671 [details]
Revised Diffs
These revised diffs address the two issues that Rich and Noriko raised.
Checked into ldapserver (HEAD). Thanks to Rich and Noriko for their reviews! /cvs/dirsec/ldapserver/ldap/servers/plugins/replication/cl5_api.c,v <-- cl5_api.c new revision: 1.16; previous revision: 1.15 done Checking in slapd/tools/dbscan.c; /cvs/dirsec/ldapserver/ldap/servers/slapd/tools/dbscan.c,v <-- dbscan.c new revision: 1.17; previous revision: 1.16 done |