Bug 304391

Summary:	Review Request: pidgin-gfire - xFire protocol plug-in for Pidgin
Product:	[Fedora] Fedora	Reporter:	Brendan Ross <downhillgames>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, xavier
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-10-30 20:16:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description Brendan Ross 2007-09-25 02:50:38 UTC

Spec URL: http://www.diffingo.com/lindox/pidgin-gfire.spec
SRPM URL: http://www.diffingo.com/lindox/pidgin-gfire-0.6.1-0.1.20070831svn.fc7.src.rpm
Description: this is a plug-in under development which allows Pidgin to connect to the popular xFire network (www.xfire.com). (This is my first package)

Comment 1 Xavier Bachelot 2007-10-20 23:47:22 UTC

- package name follows guidelines : OK
- spec file name follows guidelines : OK
- Release: follows guidelines for a pre-release : OK 
- Summary: ends with a dot and is probably too long : NOK
  suggestion : Summary: Pidgin plugin for xfire network
- Source URL is good and tarball match upstream : OK
- License: is correct, is allowed in Fedora and match sources : OK
- Text of license is packaged : OK
- BuildRoot: is correct : OK
- Typos in Description : s/incrimenting/incrementing/
  This package not supported by the official Xfire team : missing 'is' and
missing period.
- Static libs are removed : OK
- Macros are used consistently : OK
- Don't package INSTALL file, it's empty : NOK
- Don't package NEWS file, it's mostly empty and point to CHANGELOG
- BuildRequires: and Requires: are correct : OK
- Spec file is legible : OK 
- Builds fine on i386 : OK
- Rpmlint output will be clean once you've removed the empty INSTALL file and
fixed the Summary:

This is not a fully valid review, as I'm also looking for a sponsor, but I hope
it helps.

Comment 2 Brendan Ross 2007-10-30 20:16:36 UTC

I asked about packaging in #fedora-devel. If anybody else wants to package this,
be my guest. I won't comment on why I won't package things.

cya,
B.