This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes

Bug 306841

Summary: rpm-spec-mode unable to add changelog entries
Product: [Fedora] Fedora Reporter: Jeremy Katz <katzj>
Component: emacsAssignee: Chip Coldwell <coldwell>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bugs.michael, mitr, petersen, ralston, ville.skytta
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 22.1-8.fc8 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-17 00:33:11 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 235704    
Attachments:
Description Flags
xemacs compat patch none

Description Jeremy Katz 2007-09-26 08:32:17 EDT
rpm-spec-mode seems to have lost the ability to add changelog entries in
rawhide.  After doing rpm-add-change-log-entry and typing the entry, you get the
message
  rpm-spec-field-value: Invalid function: ignore-errors
and your changelog entry is lost
Comment 1 Ville Skyttä 2007-10-02 12:23:38 EDT
I think XEmacs CVS is nowadays the most advanced upstream for this mode - I
(think I) fixed this problem there for GNU Emacs some time ago:

http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/rpm-spec-mode.el.diff?r1=1.23&r2=1.24&diff_format=u
Comment 2 Jens Petersen 2007-10-15 01:55:00 EDT
Re-bytecompiling rpm-spec-mode.el by hand seems to fix the problem for me.
Not sure why it is broken or if rpm-spec-mode.el should require cl-macs at
compile time.

But it would probably be a good idea to update the latest version from XEmacs.
Comment 3 Jeremy Katz 2007-10-24 16:04:44 EDT
Thanks for the pointer Ville -- updated to the latest version and it does seem
to be fixed with it.  Building that now 
Comment 4 James Ralston 2007-11-01 15:18:43 EDT
I updated to revision 1.24 of rpm-spec-mode.el from cvs.xemacs.org.  For me, it
also breaks, but in a different manner:

Symbol's function definition is void: user-mail-address

(I have user-mail-address set to my email address in my ~/.emacs file.)

Jeremy, I'd like to test the new RPMs you're building, to see if the problem is
fixed there (as you believe it is).  Any progress on making those available in
updates-testing?
Comment 5 Chip Coldwell 2007-11-01 15:25:13 EDT
(In reply to comment #4)
> I updated to revision 1.24 of rpm-spec-mode.el from cvs.xemacs.org.  For me, it
> also breaks, but in a different manner:
> 
> Symbol's function definition is void: user-mail-address

You also need the patch:

rpm-spec-mode.el-0.14-xemacs-compat.patch

in the .src.rpm.  Attached to this BZ.

Chip
Comment 6 Chip Coldwell 2007-11-01 15:25:42 EDT
Created attachment 246021 [details]
xemacs compat patch
Comment 7 Ville Skyttä 2007-11-01 16:04:00 EDT
That patch looks partially obsolete.  The latest rpm-spec-mode.el no longer uses
"ignore-errors" so it can be dropped.  Also, Emacs 22 has
"define-obsolete-variable-alias" so it can be dropped too.

The user-mail-address thing is a real issue for GNU Emacs though, I just
committed a fix for it:
http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/rpm-spec-mode.el.diff?r1=1.24&r2=1.25&diff_format=u
Comment 8 Chip Coldwell 2007-11-01 16:17:29 EDT
(In reply to comment #7)
> That patch looks partially obsolete.  The latest rpm-spec-mode.el no longer uses
> "ignore-errors" so it can be dropped.  Also, Emacs 22 has
> "define-obsolete-variable-alias" so it can be dropped too.
> 
> The user-mail-address thing is a real issue for GNU Emacs though, I just
> committed a fix for it:
>
http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/rpm-spec-mode.el.diff?r1=1.24&r2=1.25&diff_format=u

IIUC, with this version of rpm-spec-mode we can drop the patch entirely, right?

Chip

Comment 9 James Ralston 2007-11-01 16:22:44 EDT
I just tested revision 1.25 of rpm-spec-mode.el (as-is from from cvs.xemacs.org)
with emacs-22.1-4.fc7, and rpm-add-change-log-entry works fine.  I haven't seen
any other problems so far...
Comment 10 Ville Skyttä 2007-11-01 16:36:02 EDT
(In reply to comment #8)

> IIUC, with this version of rpm-spec-mode we can drop the patch entirely, right?

Right, unless I missed something else - I don't use rpm-spec-mode with GNU Emacs
that often.
Comment 11 Fedora Update System 2007-11-08 00:59:13 EST
emacs-22.1-8.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'
Comment 12 Fedora Update System 2007-11-09 18:46:27 EST
emacs-22.1-5.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'
Comment 13 Fedora Update System 2007-11-17 00:33:06 EST
emacs-22.1-8.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 14 Fedora Update System 2007-11-17 00:34:28 EST
emacs-22.1-5.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 15 Fedora Update System 2007-12-07 16:32:56 EST
emacs-22.1-6.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'