Bug 306841

I think XEmacs CVS is nowadays the most advanced upstream for this mode - I
(think I) fixed this problem there for GNU Emacs some time ago:

http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/rpm-spec-mode.el.diff?r1=1.23&r2=1.24&diff_format=u

Re-bytecompiling rpm-spec-mode.el by hand seems to fix the problem for me.
Not sure why it is broken or if rpm-spec-mode.el should require cl-macs at
compile time.

But it would probably be a good idea to update the latest version from XEmacs.

Thanks for the pointer Ville -- updated to the latest version and it does seem
to be fixed with it.  Building that now 

I updated to revision 1.24 of rpm-spec-mode.el from cvs.xemacs.org.  For me, it
also breaks, but in a different manner:

Symbol's function definition is void: user-mail-address

(I have user-mail-address set to my email address in my ~/.emacs file.)

Jeremy, I'd like to test the new RPMs you're building, to see if the problem is
fixed there (as you believe it is).  Any progress on making those available in
updates-testing?

(In reply to comment #4)
> I updated to revision 1.24 of rpm-spec-mode.el from cvs.xemacs.org.  For me, it
> also breaks, but in a different manner:
> 
> Symbol's function definition is void: user-mail-address

You also need the patch:

rpm-spec-mode.el-0.14-xemacs-compat.patch

in the .src.rpm.  Attached to this BZ.

Chip

Created attachment 246021 [details]
xemacs compat patch

That patch looks partially obsolete.  The latest rpm-spec-mode.el no longer uses
"ignore-errors" so it can be dropped.  Also, Emacs 22 has
"define-obsolete-variable-alias" so it can be dropped too.

The user-mail-address thing is a real issue for GNU Emacs though, I just
committed a fix for it:
http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/rpm-spec-mode.el.diff?r1=1.24&r2=1.25&diff_format=u

(In reply to comment #7)
> That patch looks partially obsolete.  The latest rpm-spec-mode.el no longer uses
> "ignore-errors" so it can be dropped.  Also, Emacs 22 has
> "define-obsolete-variable-alias" so it can be dropped too.
> 
> The user-mail-address thing is a real issue for GNU Emacs though, I just
> committed a fix for it:
>
http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/rpm-spec-mode.el.diff?r1=1.24&r2=1.25&diff_format=u

IIUC, with this version of rpm-spec-mode we can drop the patch entirely, right?

Chip

I just tested revision 1.25 of rpm-spec-mode.el (as-is from from cvs.xemacs.org)
with emacs-22.1-4.fc7, and rpm-add-change-log-entry works fine.  I haven't seen
any other problems so far...

(In reply to comment #8)

> IIUC, with this version of rpm-spec-mode we can drop the patch entirely, right?

Right, unless I missed something else - I don't use rpm-spec-mode with GNU Emacs
that often.

emacs-22.1-8.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'

emacs-22.1-5.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'

emacs-22.1-8.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

emacs-22.1-5.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

emacs-22.1-6.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs'