Bug 307791

Do you really need the %post and %postun update-desktop-database?

APPROVED, with following notes:
- Dependency on glib2-devel unnecessary (pulled in by libsexy-devel)
- Requires(post), Requires(postun), %post and %postun also unnecessary
- Connecting is misspelled in upstream code and translation, patch attached.  
  Please apply and forward to upstream.

MUST

• rpmlint: OK
• package name: OK
• spec file name: OK
• package guideline-compliant: OK
• license complies with guidelines: OK
• license field accurate: OK
• license file not deleted: OK
• spec in US English: OK
• spec legible: OK
• source matches upstream: OK
• builds under >= 1 archs, others excluded: OK
• build dependencies complete: OK*
• locales handled using %find_lang: OK
• no dupes in %files: OK
• permission: OK
• %clean RPM_BUILD_ROOT: OK
• macros used consistently: OK
• Package contains code: OK
• desktop file uses desktop-file-install: OK*
• clean buildroot before install: OK
• filenames UTF-8: OK

SHOULD
• package build in mock on all architectures
• package functioned as described: OK
• require package not files: OK

Created attachment 207541 [details]
Patches spelling of "Connecting"

Doesn't this package contain trademarked icons?(In reply to comment #2)
> APPROVED, with following notes:
> - Connecting is misspelled in upstream code and translation, patch attached.  
>   Please apply and forward to upstream.

Don't bother forwarding that patch to upstream, since we're doing a complete
rewrite for the next version.

Ah, quite right -- the icon would need to be replaced

Ping. Is the plan to wait for the new release before including it in Fedora?

Daniel just releases 0.60 earlier today, which should fix the trademarked icon
issues that was holding this up.

Konstantin, any chance of an updated package to review soon?

Yeah, sorry it took so long. Quite a number of changes in this release, so the
spec has been modified heavily.

http://icon.fedorapeople.org/f/twitux.spec
http://icon.fedorapeople.org/f/twitux-0.60-1.fc8.src.rpm

(In reply to comment #9)
> Yeah, sorry it took so long. Quite a number of changes in this release, so the
> spec has been modified heavily.

Couple of quick items:
1. the post & postun update-desktop-database scriptlets are unnecessary, since
the desktopfile doesn't contain any Mimetype keys.
2. Missing BR for aspell-devel, iso-codes-devel, gnome-keyring-devel, &
dbus-devel, which will enable spell-checking support, basic NM support, and
gnome-keyring support.

Many of these BRs were pulled in by others, but I did add iso-codes-devel (why?)
and aspell-devel, which enabled spellchecking. Do we need to specifically
require iso-codes, then?

http://fedorapeople.org/~icon/f/twitux.spec
http://fedorapeople.org/~icon/f/twitux-0.60-2.fc8.src.rpm

You do need iso-codes-devel, otherwise configure reports:

checking whether iso-codes exists and has iso-639 domain... no

New Package CVS Request
=======================
Package Name: twitux
Short Description: a Twitter client for the Gnome desktop
Owners: icon
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes

cvs done.

twitux-0.60-2.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update twitux'

Please remember to close the bug once package has been built

Reopening: minor bug, the configuration file twitux.schemas needs to be marked
%config(noreplace) in the %files listing.

(In reply to comment #17)
> Reopening: minor bug, the configuration file twitux.schemas needs to be marked
> %config(noreplace) in the %files listing.

No, the schemas should not be marked noreplace, since they sometimes do need to
be replaced.

Nope, won't fix. Gconf files are not %config.

See discussions in fedora-devel, e.g.
https://www.redhat.com/archives/fedora-devel-list/2008-January/msg02033.html

Ah, OK. Seems like this won't change anytime soon, and we ought to make an
exception for this in rpmlint.

@Michel: no exceptions, please. Better do something to fix it upstream (move
schemas away from /etc to /usr/share/gconf/schemas like it's done in kde).

twitux-0.60-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.