Bug 313381
| Summary: | wpa_supplicant wakes up the cpu | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | William Lovaton <walovaton> | ||||||
| Component: | wpa_supplicant | Assignee: | Dan Williams <dcbw> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | rawhide | CC: | bnocera, mgarski | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2008-03-26 14:05:11 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 204948 | ||||||||
| Attachments: |
|
||||||||
|
Description
William Lovaton
2007-10-01 00:01:29 UTC
Created attachment 221641 [details]
Lightly tested fix against 0.5.7
I also see it, though at 1.0 wakeups/sec. I tried to fix it but the source is
hard to understand :-(. It probably wouldn't be too hard to find where it
says "1 second", change it to "5 seconds" and see if it still works.
There's no fundamentally good reason for it to wake up - if you strace the
daemon you'll see the only system call it makes is the select() call that it
sleeps on. I'm sure it's not polling information from the kernel, just doing
some internal book-keeping.
Patch Works For Me (tm). Might eat children, who knows, but should at least
point out the problem.
Warning: After testing this patch my machine went up to 320 wakeups/s with no
reason shown on powertop. I've not experienced this before and it could be
connected to my patch.
Alan; any chance you could push the patch to the hostap lists? http://w1.fi is the site; if you don't want to I could probably try to push it up. Created attachment 221841 [details]
Slightly more tested fix
The previous one only stopped wpa_supplicant showing up on powertop because it
turned it into a busy loop :-).
This one is slightly less radical in it's aim. It still uses a regular timer
tick, but it shuts it down once no timers are active. On my setup, this means
wpa_supplicant stops showing up about 15 seconds after it's started.
The obstacle to removing the regular timer tick and only waking up when an
individual timer expires is that timers can be adjusted. If a timer is enabled
while a different timer has yet to expire, you have to work out how long is
left on the existing timer, in order to find which timer will expire first. If
you rely on the system clock, "date -s" will cause problems. The only widely
available *monotonic* clock appears to be times(2).
Dan: I'm on it. I added a bug there in parallel with posting on this one. I've still got to rebase it off their current version, then I won't mind squawking on the ML if they don't pick up the bug. OK, they've implemented this now (my patch wasn't perfect and they re-wrote it). Unfortunately their Bugzilla is down right now, but if you pull the latest from their GIT repo and use that, the wakeups should be gone. git://w1.fi/srv/git/hostap.git commit: 0ac3d3876ced310e45cc68e02d9a9bebe283dfbd git-web: <http://hostap.epitest.fi/gitweb/gitweb.cgi?p=hostap.git;a=commit;h=0ac3d3876ced310e45cc68e02d9a9bebe283dfbd> This should be fixed in rawhide since we're using a dev release with your changes, right? yup, we're using 0.6.3 from early march |